Skip to content

Simplify device guard code generation#55112

Closed
wenleix wants to merge 11 commits intogh/wenleix/15/basefrom
gh/wenleix/15/head
Closed

Simplify device guard code generation#55112
wenleix wants to merge 11 commits intogh/wenleix/15/basefrom
gh/wenleix/15/head

Conversation

@wenleix
Copy link
Copy Markdown
Contributor

@wenleix wenleix commented Mar 31, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D27487085

Simplify device guard code generation
b994b7e 
Based on #47765

Differential Revision: [D27487085](https://our.internmc.facebook.com/intern/diff/D27487085/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 31, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit b583046 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Apr 09 00:08:21 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Apr 09 00:08:20 AtenXlaType function missed override: Tensor adaptive_avg_pool3d_backward(const Tensor& grad_output, const Tensor& self); // adaptive_avg_pool3d_backward(Tensor,Tensor)->Tensor
Apr 09 00:08:20 Traceback (most recent call last):
Apr 09 00:08:20   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1195, in <module>
Apr 09 00:08:20     generate(args)
Apr 09 00:08:20   File "/var/lib/jenkins/workspace/xla/scripts/gen.py", line 1165, in generate
Apr 09 00:08:20     assert check_overrides(overrides, overridden)
Apr 09 00:08:20 AssertionError
Apr 09 00:08:21 Building torch_xla version: 1.9
Apr 09 00:08:21 XLA Commit ID: 4916082169459edf81e5f0fa4032ec4b4de1f014
Apr 09 00:08:21 PyTorch Commit ID: b5830468c86575f0be6846998c00e3b401a296b7
Apr 09 00:08:21 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh']
Apr 09 00:08:21 + cleanup
Apr 09 00:08:21 + retcode=1
Apr 09 00:08:21 + set +x
Apr 09 00:08:21 =================== sccache compilation log ===================
Apr 09 00:08:21 =========== If your build fails, please take a look at the log above for possible reasons ===========
Apr 09 00:08:21 Compile requests                    4927
Apr 09 00:08:21 Compile requests executed           4603
Apr 09 00:08:21 Cache hits                          4121
Apr 09 00:08:21 Cache hits (C/C++)                  4121
Apr 09 00:08:21 Cache misses                         463

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@wenleix wenleix marked this pull request as draft March 31, 2021 23:33
wenleix pushed a commit that referenced this pull request Mar 31, 2021
Simplify device guard code generation
8da934d 
Pull Request resolved: #55112

Based on #47765
ghstack-source-id: 125446022

Differential Revision: [D27487085](https://our.internmc.facebook.com/intern/diff/D27487085/)
@wenleix
Copy link
Copy Markdown
Contributor Author

wenleix commented Mar 31, 2021 •
edited
Loading

This is based on #47765 .
With hacky wrapper removed in #54969, the logic can be further simplified

@wenleix wenleix mentioned this pull request Apr 1, 2021
Closed
@wenleix wenleix mentioned this pull request Apr 2, 2021
Closed
@wenleix wenleix marked this pull request as ready for review April 5, 2021 17:00
@wenleix wenleix requested review from bhosmer and ezyang April 5, 2021 17:03
ezyang
ezyang approved these changes Apr 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankee

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 9, 2021

This pull request has been merged in c0379ac.

@facebook-github-bot facebook-github-bot deleted the gh/wenleix/15/head branch April 13, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
@wenleix
Simplify device guard code generation (pytorch#55112)
c91b3a2 
Summary:
Pull Request resolved: pytorch#55112

Based on pytorch#47765
ghstack-source-id: 126114775

Test Plan: buck build //caffe2/aten/...

Reviewed By: ezyang

Differential Revision: D27487085

fbshipit-source-id: 157fcd19f538ce0c1e053e3e974b48bdb93a0226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@bhosmer bhosmer Awaiting requested review from bhosmer

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenleix @facebook-github-bot @ezyang