Remove use_c10_dispatcher option#54969
Closed
wenleix wants to merge 6 commits intogh/wenleix/14/basefrom
Closed
Conversation
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit eddd659 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
This was referenced Mar 30, 2021
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 30, 2021
Pull Request resolved: #54969 With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. ghstack-source-id: 125269241 Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/)
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 30, 2021
Pull Request resolved: #54969 With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. ghstack-source-id: 125278882 Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/)
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 31, 2021
Pull Request resolved: #54969 With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. ghstack-source-id: 125341486 Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/)
wenleix
commented
Mar 31, 2021
| namespace impl { | ||
|
|
||
| inline c10::optional<MemoryFormat> | ||
| check_tensor_options_and_extract_memory_format( |
Contributor
Author
There was a problem hiding this comment.
check_tensor_options_and_extract_memory_format is still required. But not sure how to rename hacky_wrapper_for_legacy_signatures.h. Use adaption.h in this PR but let me know if there is any better suggestions. cc @smessmer
Contributor
There was a problem hiding this comment.
check_tensor_options_and_extract_memory_format is actually a good example of another thing we need to get rid of; it's due to MemoryFormat being a separate argument in some JIT schema but also being specified in TensorOptions.
smessmer
reviewed
Mar 31, 2021
|
|
||
| class Locals(threading.local): | ||
| use_c10_dispatcher: Optional[UseC10Dispatcher] = None | ||
| _locals = Locals() |
Contributor
There was a problem hiding this comment.
This looks like we can remove the whole Locals class, cc @ezyang did you want to use it for something else?
Contributor
There was a problem hiding this comment.
@wenleix and I chatted about it, and it might make sense to keep this around for a little bit, in case there's some other incremental refactoring we need to do (I don't think we're done, btw)
Contributor
Author
There was a problem hiding this comment.
Discussed this offline with @ezyang . Supporting dynamic scoping during codegen seems a useful feature (e.g. other refactor) , plus is not very much code.
smessmer
approved these changes
Mar 31, 2021
Contributor
smessmer
left a comment
There was a problem hiding this comment.
Yay :) Stoked to finally get rid of hacky_wrapper
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 31, 2021
Pull Request resolved: #54969 With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. ghstack-source-id: 125401584 Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/)
With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/) [ghstack-poisoned]
wenleix
pushed a commit
that referenced
this pull request
Mar 31, 2021
Pull Request resolved: #54969 With all use cases to hacky wrapper removed, all kernels will be dispatched with c10 full dispatcher. ghstack-source-id: 125434790 Differential Revision: [D27436596](https://our.internmc.facebook.com/intern/diff/D27436596/)
Contributor
|
This pull request has been merged in 70af5db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
With all use cases to hacky wrapper removed, all kernels will be
dispatched with c10 full dispatcher.
Differential Revision: D27436596