Skip to content

Fix bug in assertRaises NotImplemented handling when no exception is thrown#54126

Closed
ezyang wants to merge 2 commits intogh/ezyang/953/basefrom
gh/ezyang/953/head
Closed

Fix bug in assertRaises NotImplemented handling when no exception is thrown#54126
ezyang wants to merge 2 commits intogh/ezyang/953/basefrom
gh/ezyang/953/head

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Mar 17, 2021 •
edited
Loading

Stack from ghstack:

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D27109510

@ezyang
Fix bug in assertRaises NotImplemented handling when no exception is …
8ca7dd7 
…thrown

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 17, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0fae429 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Mar 17 15:59:28 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_mask_rcnn FAILED [ 67%] 
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_no_initial_state_without_sequence_lengths_with_dropout PASSED [ 65%]
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_no_initial_state_without_sequence_lengths_without_dropout PASSED [ 66%]
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_with_batch_first_sequence_lengths_with_dropout PASSED [ 66%]
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_with_batch_first_sequence_lengths_without_dropout PASSED [ 66%]
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_with_variable_length_sequences_with_dropout PASSED [ 66%]
Mar 17 15:59:07 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_with_variable_length_sequences_without_dropout PASSED [ 66%]
Mar 17 15:59:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_without_sequence_lengths_with_dropout PASSED [ 66%]
Mar 17 15:59:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lstm_unilayer_forward_with_initial_state_without_sequence_lengths_without_dropout PASSED [ 67%]
Mar 17 15:59:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lt PASSED [ 67%]
Mar 17 15:59:08 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_lt_scalar PASSED [ 67%]
Mar 17 15:59:28 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_mask_rcnn FAILED [ 67%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_masked_fill PASSED [ 67%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_masked_fill_inplace PASSED [ 67%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_masked_scatter PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_masked_select PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_matmul PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_matmul_batch PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_max_tensors PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_maxpool PASSED [ 68%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_maxpool_1d_ceil PASSED [ 69%]
Mar 17 15:59:29 test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime_opset11::test_maxpool_2d PASSED [ 69%]
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
@ezyang ezyang requested a review from mruberry March 17, 2021 13:58
@ezyang
Update on "Fix bug in assertRaises NotImplemented handling when no ex…
0fae429 
…ception is thrown"

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: [D27109510](https://our.internmc.facebook.com/intern/diff/D27109510)

[ghstack-poisoned]
mruberry
mruberry approved these changes Mar 17, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 17, 2021

@ezyang merged this pull request in a2a7179.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/953/head branch March 21, 2021 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@ezyang @facebook-github-bot
Fix bug in assertRaises NotImplemented handling when no exception is …
9847225 
…thrown (pytorch#54126)

Summary:
Pull Request resolved: pytorch#54126

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: agolynski, mruberry

Differential Revision: D27109510

Pulled By: ezyang

fbshipit-source-id: ba5a4de85ca00f81724f3d4e645797e8f32aa3b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @facebook-github-bot @mruberry