Fix inaccurate dispatch tables#54127
Closed
ezyang wants to merge 5 commits intogh/ezyang/954/basefrom
Closed
Conversation
During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Mar 17, 2021
Contributor
💊 CI failures summary and remediationsAs of commit e20fb81 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27109508](https://our.internmc.facebook.com/intern/diff/D27109508) [ghstack-poisoned]
During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27109508](https://our.internmc.facebook.com/intern/diff/D27109508) [ghstack-poisoned]
During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27109508](https://our.internmc.facebook.com/intern/diff/D27109508) [ghstack-poisoned]
mruberry
approved these changes
Mar 18, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Nice cleanup. As mentioned on another PR:
- is there a way to test for this so new incorrect dispatches can't accumulate?
- are there clearer names we can use than "DefaultBackend" or "Math"? "DefaultBackend" seems to be especially confusing.
During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27109508](https://our.internmc.facebook.com/intern/diff/D27109508) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#54127 During the meta tensor bringup, I found all of these operators advertised that they worked on all backends (DefaultBackend/Math) but actually they only worked on CPU/CUDA. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D27109508 Pulled By: ezyang fbshipit-source-id: 0f474ecf4aba8b8207f2910bdc962bf581f53853
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
During the meta tensor bringup, I found all of these operators
advertised that they worked on all backends (DefaultBackend/Math)
but actually they only worked on CPU/CUDA.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D27109508