Make storage access error NotImplementedError#53972
Closed
ezyang wants to merge 6 commits intogh/ezyang/944/basefrom
Closed
Make storage access error NotImplementedError#53972ezyang wants to merge 6 commits intogh/ezyang/944/basefrom
ezyang wants to merge 6 commits intogh/ezyang/944/basefrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit ec277ac (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 14, 2021
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036573](https://our.internmc.facebook.com/intern/diff/D27036573) [ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036573](https://our.internmc.facebook.com/intern/diff/D27036573) [ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036573](https://our.internmc.facebook.com/intern/diff/D27036573) [ghstack-poisoned]
This was referenced Mar 15, 2021
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036573](https://our.internmc.facebook.com/intern/diff/D27036573) [ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036573](https://our.internmc.facebook.com/intern/diff/D27036573) [ghstack-poisoned]
albanD
reviewed
Mar 15, 2021
|
|
||
| void TensorImpl::throw_storage_access_error() const { | ||
| TORCH_CHECK(false, "Cannot access storage of ", tensorimpl_type_name()); | ||
| TORCH_CHECK_NOT_IMPLEMENTED(false, "Cannot access storage of ", tensorimpl_type_name()); |
Collaborator
There was a problem hiding this comment.
Well this one is not strictly a not implemented error? Maybe more of a TypeError?
But if that makes the whole Meta testing simpler, I understand :D
Contributor
Author
There was a problem hiding this comment.
Yeah, this PR is kind of wrong, but it is "easier"; because I then need to go fix the test suite to stop assuming that there is a storage(). If you like I can remove this from the stack and maintain this in my slush patch until I get far enough that I don't need it anymore.
Collaborator
There was a problem hiding this comment.
Ok I think it is ok if it makes things easier.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#53972 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D27036573 Pulled By: ezyang fbshipit-source-id: 5cc7d9e124bd27ca4041feb56b5007d9408d622a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D27036573