Also propagate storage_access_should_throw_ when copying tensor metadata#53816
Closed
ezyang wants to merge 8 commits intogh/ezyang/942/basefrom
Closed
Also propagate storage_access_should_throw_ when copying tensor metadata#53816ezyang wants to merge 8 commits intogh/ezyang/942/basefrom
ezyang wants to merge 8 commits intogh/ezyang/942/basefrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Mar 11, 2021
Contributor
💊 CI failures summary and remediationsAs of commit eac9020 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
Contributor
|
What if you copy_tensor_metadata from a TensorImpl whose storage access should throw(say, a SparseTensorImpl) into one where it shouldn't (say, regular old TensorImpl)? The TensorImpl public interface permits this. |
Contributor
Author
|
@swolchok I suspect there's an implicit contract saying that the subclass has to be the same in the source and the destination. Would have to add an assert to this effect to check though. FWIW copying sparse tensor's metadata into a dense tensor is pretty bonkers and not something you ever actually want to do. |
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Mar 14, 2021
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036574](https://our.internmc.facebook.com/intern/diff/D27036574) [ghstack-poisoned]
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036574](https://our.internmc.facebook.com/intern/diff/D27036574) [ghstack-poisoned]
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036574](https://our.internmc.facebook.com/intern/diff/D27036574) [ghstack-poisoned]
This was referenced Mar 15, 2021
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036574](https://our.internmc.facebook.com/intern/diff/D27036574) [ghstack-poisoned]
…ensor metadata" Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D27036574](https://our.internmc.facebook.com/intern/diff/D27036574) [ghstack-poisoned]
This was referenced Mar 15, 2021
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ata (pytorch#53816) Summary: Pull Request resolved: pytorch#53816 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D27036574 Pulled By: ezyang fbshipit-source-id: 71e61b0aa3d46159c9af1112c262cbfa7eaa1879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D27036574