add missing return statement to inlined vec_signed#51116
add missing return statement to inlined vec_signed#51116dncliss wants to merge 1 commit intopytorch:masterfrom
Conversation
|
Hi @dncliss! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit 57ff7cd (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@malfet -- I've taken the liberty of trying to correct the small error in the referenced PR myself, here via this new PR. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #51116 +/- ##
==========================================
- Coverage 80.89% 80.89% -0.01%
==========================================
Files 1928 1928
Lines 210486 210486
==========================================
- Hits 170267 170263 -4
- Misses 40219 40223 +4 |
Summary:
Fixes #{issue number}
This is not really a new issue, just a proposed minor fix to a recent previous issue (now closed) pytorch#50640 which was a fix for pytorch#50439.
That fix added inlining for vec_signed (and others) but in one case the return was accidentally omitted. This results in a build error:
``` from �[01m�[K../aten/src/ATen/cpu/vec256/vec256.h:19�[m�[K,
from �[01m�[Katen/src/ATen/native/cpu/FillKernel.cpp.VSX.cpp:3�[m�[K:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:�[m�[K In function ‘�[01m�[Kvint32 vec_signed(const vfloat32&)�[m�[K’:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:33:1:�[m�[K �[01;31m�[Kerror: �[m�[Kno return statement in function returning non-void [�[01;31m�[K-Werror=return-type�[m�[K]
```
I've confirmed that the error disappears after this one-line fix. (Note: There is another issue encountered later in the build unrelated to this particular fix, as I noted in a separate comment in the original issue. I'm trying to make some sense of that one, but in any event it would be a subject for another issue/PR).
Pull Request resolved: pytorch#51116
Reviewed By: heitorschueroff
Differential Revision: D26078213
Pulled By: malfet
fbshipit-source-id: 59b2ee19138fa1b8d8ec1d35ca4a5ef0a67bc123
Fixes #{issue number}
This is not really a new issue, just a proposed minor fix to a recent previous issue (now closed) #50640 which was a fix for #50439.
That fix added inlining for vec_signed (and others) but in one case the return was accidentally omitted. This results in a build error:
I've confirmed that the error disappears after this one-line fix. (Note: There is another issue encountered later in the build unrelated to this particular fix, as I noted in a separate comment in the original issue. I'm trying to make some sense of that one, but in any event it would be a subject for another issue/PR).