[PPC] Add missing vec_[signed|neg|sldw] definitions#50640
Closed
[PPC] Add missing vec_[signed|neg|sldw] definitions#50640
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
walterddr
approved these changes
Jan 21, 2021
Base on @quickwritereader 's comment: #50439 (comment) Those builtins were added in gcc-8 or newer
281b579 to
c1d64c9
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #50640 +/- ##
==========================================
- Coverage 81.02% 81.02% -0.01%
==========================================
Files 1916 1916
Lines 209343 209343
==========================================
- Hits 169624 169616 -8
- Misses 39719 39727 +8 |
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
Summary:
Fixes #{issue number}
This is not really a new issue, just a proposed minor fix to a recent previous issue (now closed) #50640 which was a fix for #50439.
That fix added inlining for vec_signed (and others) but in one case the return was accidentally omitted. This results in a build error:
``` from �[01m�[K../aten/src/ATen/cpu/vec256/vec256.h:19�[m�[K,
from �[01m�[Katen/src/ATen/native/cpu/FillKernel.cpp.VSX.cpp:3�[m�[K:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:�[m�[K In function ‘�[01m�[Kvint32 vec_signed(const vfloat32&)�[m�[K’:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:33:1:�[m�[K �[01;31m�[Kerror: �[m�[Kno return statement in function returning non-void [�[01;31m�[K-Werror=return-type�[m�[K]
```
I've confirmed that the error disappears after this one-line fix. (Note: There is another issue encountered later in the build unrelated to this particular fix, as I noted in a separate comment in the original issue. I'm trying to make some sense of that one, but in any event it would be a subject for another issue/PR).
Pull Request resolved: #51116
Reviewed By: heitorschueroff
Differential Revision: D26078213
Pulled By: malfet
fbshipit-source-id: 59b2ee19138fa1b8d8ec1d35ca4a5ef0a67bc123
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Base on quickwritereader 's comment: pytorch#50439 (comment) Those builtins were added in gcc-8 or newer Fixes pytorch#50439 Pull Request resolved: pytorch#50640 Reviewed By: walterddr Differential Revision: D25934384 Pulled By: malfet fbshipit-source-id: b5dcfcf644ab92a78279c4dca5dbffbb8d8aae0c
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary:
Fixes #{issue number}
This is not really a new issue, just a proposed minor fix to a recent previous issue (now closed) pytorch#50640 which was a fix for pytorch#50439.
That fix added inlining for vec_signed (and others) but in one case the return was accidentally omitted. This results in a build error:
``` from �[01m�[K../aten/src/ATen/cpu/vec256/vec256.h:19�[m�[K,
from �[01m�[Katen/src/ATen/native/cpu/FillKernel.cpp.VSX.cpp:3�[m�[K:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:�[m�[K In function ‘�[01m�[Kvint32 vec_signed(const vfloat32&)�[m�[K’:
�[01m�[K../aten/src/ATen/cpu/vec256/vsx/vsx_helpers.h:33:1:�[m�[K �[01;31m�[Kerror: �[m�[Kno return statement in function returning non-void [�[01;31m�[K-Werror=return-type�[m�[K]
```
I've confirmed that the error disappears after this one-line fix. (Note: There is another issue encountered later in the build unrelated to this particular fix, as I noted in a separate comment in the original issue. I'm trying to make some sense of that one, but in any event it would be a subject for another issue/PR).
Pull Request resolved: pytorch#51116
Reviewed By: heitorschueroff
Differential Revision: D26078213
Pulled By: malfet
fbshipit-source-id: 59b2ee19138fa1b8d8ec1d35ca4a5ef0a67bc123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base on @quickwritereader 's comment: #50439 (comment)
Those builtins were added in gcc-8 or newer
Fixes #50439