[BE] .gitignore adding test-reports/ folder#50952
[BE] .gitignore adding test-reports/ folder#50952walterddr wants to merge 2 commits intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 8aeca4d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
samestep
left a comment
There was a problem hiding this comment.
I see that test/test-reports/ is already present in that .gitignore (line 54), so that should be removed since this one makes it redundant; also could you give an example of a scenario where a test-reports/ dir is generated that is not in test/?
facebook-github-bot
left a comment
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@walterddr merged this pull request in 7b12893. |
Summary: Cant think of a reason not .gitignore test-reports folder. this can be helpful when 1. running `python test/test*.py` from github root directory since it creates the folder at root. 2. CI test report path generated by `torch/testing/_internal/common_utils.py` creates the folder in the same path where the test python file locates. Creating a PR to make sure CI is happy. this is also needed by pytorch#50923 Pull Request resolved: pytorch#50952 Reviewed By: samestep Differential Revision: D26022436 Pulled By: walterddr fbshipit-source-id: 83e6296de802bd1754b802b8c70502c317f078c9
Cant think of a reason not .gitignore test-reports folder. this can be helpful when
python test/test*.pyfrom github root directory since it creates the folder at root.torch/testing/_internal/common_utils.pycreates the folder in the same path where the test python file locates.Creating a PR to make sure CI is happy. this is also needed by #50923