[BE] move more unittest.main() to run_tests()#50923
Closed
walterddr wants to merge 2 commits intopytorch:masterfrom
Closed
[BE] move more unittest.main() to run_tests()#50923walterddr wants to merge 2 commits intopytorch:masterfrom
walterddr wants to merge 2 commits intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit c3339f5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
f7a70a5 to
e6d96fb
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
Summary: Cant think of a reason not .gitignore test-reports folder. this can be helpful when 1. running `python test/test*.py` from github root directory since it creates the folder at root. 2. CI test report path generated by `torch/testing/_internal/common_utils.py` creates the folder in the same path where the test python file locates. Creating a PR to make sure CI is happy. this is also needed by #50923 Pull Request resolved: #50952 Reviewed By: samestep Differential Revision: D26022436 Pulled By: walterddr fbshipit-source-id: 83e6296de802bd1754b802b8c70502c317f078c9
e6d96fb to
c3339f5
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #50923 +/- ##
==========================================
- Coverage 80.74% 80.61% -0.13%
==========================================
Files 1920 1920
Lines 209749 209749
==========================================
- Hits 169369 169097 -272
- Misses 40380 40652 +272 |
Contributor
|
@walterddr merged this pull request in 806010b. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Cant think of a reason not .gitignore test-reports folder. this can be helpful when 1. running `python test/test*.py` from github root directory since it creates the folder at root. 2. CI test report path generated by `torch/testing/_internal/common_utils.py` creates the folder in the same path where the test python file locates. Creating a PR to make sure CI is happy. this is also needed by pytorch#50923 Pull Request resolved: pytorch#50952 Reviewed By: samestep Differential Revision: D26022436 Pulled By: walterddr fbshipit-source-id: 83e6296de802bd1754b802b8c70502c317f078c9
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Relate to pytorch#50483. Everything except ONNX, detectron and release notes tests are moved to use common_utils.run_tests() to ensure CI reports XML correctly. Pull Request resolved: pytorch#50923 Reviewed By: samestep Differential Revision: D26027621 Pulled By: walterddr fbshipit-source-id: b04c03f10d1fe96181b720c4c3868e86e4c6281a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate to #50483.
Everything except ONNX, detectron and release notes tests are moved to use common_utils.run_tests() to ensure CI reports XML correctly.