Stop moving scalars to GPU for one computation in leaky_rrelu_backward.#50115
Closed
gchanan wants to merge 7 commits intogh/gchanan/351/basefrom
Closed
Stop moving scalars to GPU for one computation in leaky_rrelu_backward.#50115gchanan wants to merge 7 commits intogh/gchanan/351/basefrom
gchanan wants to merge 7 commits intogh/gchanan/351/basefrom
Conversation
There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758.
Contributor
💊 CI failures summary and remediationsAs of commit 8268cef (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 44 times. |
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
…elu_backward." There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758. Differential Revision: [D25790331](https://our.internmc.facebook.com/intern/diff/D25790331)
Contributor
Author
|
this is tested in test_nn.py::TestNN::test_RReLU. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…d. (pytorch#50115) Summary: Pull Request resolved: pytorch#50115 There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see pytorch#49758. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D25790331 Pulled By: gchanan fbshipit-source-id: 89d6f016dfd76197541b0fd8da4a462876dbf844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There is no way this is performant and we are trying to minimize the usage of scalar_to_tensor(..., device) since it is an anti-pattern, see #49758.
Differential Revision: D25790331