Stop using an unnecessary scalar_to_tensor(..., device) call.#50114
Closed
gchanan wants to merge 7 commits intogh/gchanan/350/basefrom
Closed
Stop using an unnecessary scalar_to_tensor(..., device) call.#50114gchanan wants to merge 7 commits intogh/gchanan/350/basefrom
gchanan wants to merge 7 commits intogh/gchanan/350/basefrom
Conversation
In this case, the function only dispatches on cpu anyway.
This was referenced Jan 5, 2021
Contributor
💊 CI failures summary and remediationsAs of commit da49573 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 45 times. |
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll." In this case, the function only dispatches on cpu anyway. Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
Contributor
Author
|
this is tested, see: #50376. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…h#50114) Summary: Pull Request resolved: pytorch#50114 In this case, the function only dispatches on cpu anyway. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D25790155 Pulled By: gchanan fbshipit-source-id: 799dc9a3a38328a531ced9e85ad2b4655533e86a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In this case, the function only dispatches on cpu anyway.
Differential Revision: D25790155