Avg pool 0 dim acceptance.#50008
Conversation
…e pool2d_shape_check function instead of computing it inside the function
💊 CI failures summary and remediationsAs of commit cfe4f06 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 12 times. |
Codecov Report
@@ Coverage Diff @@
## master #50008 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 1901 1901
Lines 206255 206255
=======================================
+ Hits 166421 166423 +2
+ Misses 39834 39832 -2 |
rgommers
left a comment
There was a problem hiding this comment.
All green, so should be good to land again.
| with torch.backends.cudnn.flags(enabled=False): | ||
| self._test_module_empty_input(mod, inp, check_size=False) | ||
|
|
||
| @onlyOnCPUAndCUDA |
There was a problem hiding this comment.
This is the skip for the failure in #47426 (comment). Cc @JackCaoG, the question from the other PR is still open - if this should be fixed for XLA, does a separate issue to track it need opening, or is pinging you enough?
There was a problem hiding this comment.
@rgomathi Sorry for missing the previous email, it is safe to skip RuntimeError not raised error for pt/xla.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Reopen pytorch#47426 since it failed for XLA tests. Pull Request resolved: pytorch#50008 Reviewed By: mruberry Differential Revision: D25857687 Pulled By: ngimel fbshipit-source-id: 8bd47a17b417b20089cf003173d8c0793be58c72
Reopen #47426 since it failed for XLA tests.