Skip to content

Reopen PR for 0 dim batch size for AvgPool2d.#47426

Closed
v0dro wants to merge 12 commits intopytorch:masterfrom
v0dro:avg-pool-0-dim
Closed

Reopen PR for 0 dim batch size for AvgPool2d.#47426
v0dro wants to merge 12 commits intopytorch:masterfrom
v0dro:avg-pool-0-dim

Conversation

@v0dro
Copy link
Copy Markdown
Contributor

@v0dro v0dro commented Nov 5, 2020

Resubmitting #40694 since it could not be landed for some reason.

CC @ngimel

@bdhirsh bdhirsh requested a review from ngimel November 6, 2020 17:08
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 6, 2020
@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented Nov 11, 2020

Can you please resolve a conflict?

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Nov 13, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ee17e1b (more details on the Dr. CI page):

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

facebook-github-bot
facebook-github-bot reviewed Nov 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 14, 2020

@ngimel merged this pull request in ceeab70.

@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented Nov 14, 2020

Unlanding, xla error is real.

Nov 14 03:53:56 ======================================================================
Nov 14 03:53:56 FAIL [0.077s]: test_AvgPool2d_empty_xla (__main__.TestNNDeviceTypeXLA)
Nov 14 03:53:56 ----------------------------------------------------------------------
Nov 14 03:53:56 Traceback (most recent call last):
Nov 14 03:53:56   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 272, in instantiated_test
Nov 14 03:53:56     result = test_fn(self, *args)
Nov 14 03:53:56   File "/var/lib/jenkins/workspace/xla/test/../../test/test_nn.py", line 10477, in test_AvgPool2d_empty
Nov 14 03:53:56     avgpool(inp)
Nov 14 03:53:56 AssertionError: RuntimeError not raised
Nov 14 03:53:56

@JackCaoG should we skip the xla test, or should it be fixed on the xla side?

@rgommers
Copy link
Copy Markdown
Collaborator

rgommers commented Nov 29, 2020

The revert was in commit 982ae98. @v0dro can you resubmit with a skip for XLA, so this doesn't fall through the cracks?

@v0dro v0dro mentioned this pull request Jan 3, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Jan 10, 2021
@v0dro @facebook-github-bot
Avg pool 0 dim acceptance. (#50008)
375c30a 
Summary:
Reopen #47426 since it failed for XLA tests.

Pull Request resolved: #50008

Reviewed By: mruberry

Differential Revision: D25857687

Pulled By: ngimel

fbshipit-source-id: 8bd47a17b417b20089cf003173d8c0793be58c72
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@v0dro @facebook-github-bot
Reopen PR for 0 dim batch size for AvgPool2d. (pytorch#47426)
7bcc67a 
Summary:
Resubmitting pytorch#40694 since it could not be landed for some reason.

CC ngimel

Pull Request resolved: pytorch#47426

Reviewed By: mruberry

Differential Revision: D24941350

Pulled By: ngimel

fbshipit-source-id: b7e50346d86eb63aaaf4fdd5ee71fafee2d0b476
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@v0dro @facebook-github-bot
Avg pool 0 dim acceptance. (pytorch#50008)
c6c382d 
Summary:
Reopen pytorch#47426 since it failed for XLA tests.

Pull Request resolved: pytorch#50008

Reviewed By: mruberry

Differential Revision: D25857687

Pulled By: ngimel

fbshipit-source-id: 8bd47a17b417b20089cf003173d8c0793be58c72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v0dro @ngimel @facebook-github-bot @rgommers @bdhirsh @pytorchbot