Skip to content

Set USE_KINETO=1#49897

Closed
ilia-cher wants to merge 6 commits intogh/ilia-cher/94/basefrom
gh/ilia-cher/94/head
Closed

Set USE_KINETO=1#49897
ilia-cher wants to merge 6 commits intogh/ilia-cher/94/basefrom
gh/ilia-cher/94/head

Conversation

@ilia-cher
Copy link
Copy Markdown
Contributor

@ilia-cher ilia-cher commented Dec 28, 2020 •
edited
Loading

Stack from ghstack:

Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: D25717102

Set USE_KINETO=1
5c31da2 
Summary:
Resend of #49201

Test Plan:
see 49201

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 28, 2020
Set USE_KINETO=1
b5bd3bc 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: de13574
Pull Request resolved: #49897
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4aeceac (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@ilia-cher ilia-cher requested a review from malfet December 28, 2020 20:27
@ilia-cher ilia-cher mentioned this pull request Dec 28, 2020
Closed
@ilia-cher ilia-cher requested review from ngimel and robieta December 28, 2020 20:54
@ilia-cher
Copy link
Copy Markdown
Contributor Author

ilia-cher commented Dec 28, 2020

I reverted earlier 49201 because of some ddp test failures in one of the master builds, will investigate

@ilia-cher ilia-cher mentioned this pull request Dec 28, 2020
Closed
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Dec 29, 2020

@ilia-cher please make sure to check that your PR does not add any direct dependencies against libcuda.so (i.e. PyTorch build with CUDA should be loadable on systems that do not have CUDA driver installed)

@ilia-cher
Copy link
Copy Markdown
Contributor Author

ilia-cher commented Dec 29, 2020

@ilia-cher please make sure to check that your PR does not add any direct dependencies against libcuda.so (i.e. PyTorch build with CUDA should be loadable on systems that do not have CUDA driver installed)

yes, I think we should be fine - we only compile cupti and kineto statically, and CI has non-CUDA builds as well

@ilia-cher
Copy link
Copy Markdown
Contributor Author

ilia-cher commented Jan 20, 2021

CI looks good (mod. two unrelated failures)

Update on "Set USE_KINETO=1"
deab0ae 
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Set USE_KINETO=1
1748e97 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 492652c
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 20, 2021
Closed
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Set USE_KINETO=1
61c3fee 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 492652c
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 20, 2021
Closed
Update on "Set USE_KINETO=1"
e3cf858 
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
@ilia-cher ilia-cher requested a review from albanD as a code owner January 20, 2021 15:38
Update on "Set USE_KINETO=1"
d1d5427 
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Set USE_KINETO=1
ac2cdb6 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 4a7c94b
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 20, 2021
Closed
Update on "Set USE_KINETO=1"
466e7f6 
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Set USE_KINETO=1
540f2da 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 3c05d88
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 20, 2021
Closed
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Set USE_KINETO=1
49efd43 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 3c05d88
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 20, 2021
Closed
Update on "Set USE_KINETO=1"
4aeceac 
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 21, 2021
Set USE_KINETO=1
06e66e2 
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 9aee222
Pull Request resolved: #49897
@ilia-cher ilia-cher mentioned this pull request Jan 21, 2021
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2021

Codecov Report

Merging #49897 (4aeceac) into gh/ilia-cher/94/base (1cce4c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           gh/ilia-cher/94/base   #49897      +/-   ##
========================================================
- Coverage                 81.02%   81.02%   -0.01%     
========================================================
  Files                      1916     1916              
  Lines                    209349   209349              
========================================================
- Hits                     169628   169621       -7     
- Misses                    39721    39728       +7

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 22, 2021

@ilia-cher merged this pull request in e34992e.

@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/94/head branch January 25, 2021 15:18
ngimel
ngimel reviewed Jan 26, 2021
View reviewed changes
Comment thread cmake/Dependencies.cmake
message(STATUS " KINETO_LIBRARY_TYPE = ${KINETO_LIBRARY_TYPE}")
message(STATUS " CUDA_SOURCE_DIR = ${CUDA_SOURCE_DIR}")

if(EXISTS ${CUDA_SOURCE_DIR}/extras/CUPTI/lib64/libcupti_static.a)
Copy link
Copy Markdown
Collaborator

@ngimel ngimel Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use CUDA_cupti_LIBRARY found by FindCUDA here? Also, see #51026, USE_CUPTI_SO should be given preference.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Set USE_KINETO=1 (pytorch#49897)
e0b5154 
Summary:
Pull Request resolved: pytorch#49897

Resend of pytorch#49201

Test Plan: see 49201

Reviewed By: malfet

Differential Revision: D25717102

Pulled By: ilia-cher

fbshipit-source-id: 5e794a7f5fe160ca64ac9d190c4fd3e8f1e443e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel left review comments

@malfet malfet malfet approved these changes

@robieta robieta Awaiting requested review from robieta

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilia-cher @facebook-github-bot @malfet @ngimel