Skip to content

Set USE_KINETO=1#49201

Closed
ilia-cher wants to merge 20 commits intogh/ilia-cher/90/basefrom
gh/ilia-cher/90/head
Closed

Set USE_KINETO=1#49201
ilia-cher wants to merge 20 commits intogh/ilia-cher/90/basefrom
gh/ilia-cher/90/head

Conversation

@ilia-cher
Copy link
Copy Markdown
Contributor

@ilia-cher ilia-cher commented Dec 10, 2020

Stack from ghstack:

Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: D25480770

Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 10, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: de304c3
Pull Request resolved: #49201
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 10, 2020

💊 CI failures summary and remediations

As of commit 69d1d9a (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 18 08:57:40 AssertionError: False is not true : Scalars failed to compare as equal! Comparing -6 and 0 gives a difference of 6, but the allowed difference with rtol=0 and atol=0 is only 0!
Dec 18 08:57:40 ----------------------------------------------------------------------
Dec 18 08:57:40 Traceback (most recent call last):
Dec 18 08:57:40   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 280, in wrapper
Dec 18 08:57:40     self._join_processes(fn)
Dec 18 08:57:40   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 397, in _join_processes
Dec 18 08:57:40     self._check_return_codes(elapsed_time)
Dec 18 08:57:40   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 452, in _check_return_codes
Dec 18 08:57:40     msg="Expected zero exit code but got {}".format(first_process.exitcode)
Dec 18 08:57:40   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1219, in assertEqual
Dec 18 08:57:40     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
Dec 18 08:57:40 AssertionError: False is not true : Scalars failed to compare as equal! Comparing -6 and 0 gives a difference of 6, but the allowed difference with rtol=0 and atol=0 is only 0!
Dec 18 08:57:40 Expected zero exit code but got -6
Dec 18 08:57:40 
Dec 18 08:57:40 ----------------------------------------------------------------------
Dec 18 08:57:40 Ran 150 tests in 38.458s
Dec 18 08:57:40 
Dec 18 08:57:40 FAILED (failures=12, errors=12, skipped=16)
Dec 18 08:57:40 
Dec 18 08:57:40 Generating XML reports...
Dec 18 08:57:40 Generated XML report: test-reports/python-unittest/TEST-CommTest-20201218085701.xml
Dec 18 08:57:40 Generated XML report: test-reports/python-unittest/TEST-ComputeBucketAssignmentTest-20201218085701.xml

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (2/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: "Simulate error" does not match "grad can be implicitly created only for scalar outputs"

Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 273, in instantiated_test
    result = test_fn(self, *args)
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 651, in only_fn
    return fn(slf, device, *args, **kwargs)
  File "test_autograd.py", line 6635, in test_reentrant_parent_error_on_cpu
    self._test_reentrant_parent_error_on_cpu(device)
  File "test_autograd.py", line 6621, in _test_reentrant_parent_error_on_cpu
    torch.autograd.backward([t5.sum(), t7.sum()])
AssertionError: "Simulate error" does not match "grad can be implicitly created only for scalar outputs"

----------------------------------------------------------------------
Ran 2900 tests in 2110.686s

FAILED (failures=1, skipped=24, expected failures=1)

Generating XML reports...
Generated XML report: test-reports\python-unittest\TEST-TestAutograd-20201218064013.xml
Generated XML report: test-reports\python-unittest\TEST-TestAutogradComplex-20201218064013.xml
Generated XML report: test-reports\python-unittest\TEST-TestAutogradDeviceTypeCPU-20201218064013.xml

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

[ FAILED ] TensorTest.RequiresGradInplace
[  FAILED  ] SerializeTest.Optim_RMSprop
[  FAILED  ] SerializeTest.Optim_LBFGS
[  FAILED  ] SerializeTest.XOR_CUDA
[  FAILED  ] TensorTest.ToOptionsWithRequiresGrad
[  FAILED  ] TensorTest.TorchTensorCtorSingleDimFloatingType
[  FAILED  ] TensorTest.BackwardAndGrad
[  FAILED  ] TensorTest.BackwardNonScalarOutputs
[  FAILED  ] TensorTest.IsLeaf
[  FAILED  ] TensorTest.Version
[  FAILED  ] TensorTest.Detach
[  FAILED  ] TensorTest.RequiresGradInplace

188 FAILED TESTS
+ cleanup
+ retcode=1
+ set +x


Exited with code exit status 1


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 111 times.

Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please do not merge this change unless CI is green after rebasing this PR against viable/strict

Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 11, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: c146305
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 11, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: 519eb14
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 16, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: 51b014d
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 16, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: ba86754
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 17, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6675142
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 17, 2020
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

ghstack-source-id: edca588
Pull Request resolved: #49201
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
#48391

TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record

Reviewers:ngimel, robieta, nshulga

Subscribers:

Tasks:

Tags:

Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770)

[ghstack-poisoned]
@mrshenli
Copy link
Copy Markdown
Contributor

mrshenli commented Dec 18, 2020

Looks like this PR breaks DDP tests on master?
Please ignore, just realized this is already reverted.

@ilia-cher
Copy link
Copy Markdown
Contributor Author

had to revert because of ddp test failure, will resend

@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/90/head branch December 21, 2020 15:21
@ilia-cher ilia-cher mentioned this pull request Dec 28, 2020
ilia-cher pushed a commit that referenced this pull request Dec 28, 2020
Summary:
Resend of #49201

Test Plan:
see 49201

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Dec 28, 2020
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: de13574
Pull Request resolved: #49897
@ilia-cher
Copy link
Copy Markdown
Contributor Author

resending in #49897

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Summary:
Pull Request resolved: pytorch#49201

This unblocks kineto profiler for 1.8 release.
This PR supercedes pytorch#48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
pytorch#48391

Imported from OSS

Reviewed By: ngimel

Differential Revision: D25480770

fbshipit-source-id: 037cd774f5547d9918d6055ef5cc952a54e48e4c
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 492652c
Pull Request resolved: #49897
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 492652c
Pull Request resolved: #49897
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 4a7c94b
Pull Request resolved: #49897
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 3c05d88
Pull Request resolved: #49897
ilia-cher pushed a commit that referenced this pull request Jan 20, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 3c05d88
Pull Request resolved: #49897
ilia-cher pushed a commit that referenced this pull request Jan 21, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request Jan 21, 2021
Summary:
Resend of #49201

Test Plan:
see 49201

ghstack-source-id: 9aee222
Pull Request resolved: #49897
facebook-github-bot pushed a commit that referenced this pull request Jan 22, 2021
Summary:
Pull Request resolved: #49897

Resend of #49201

Test Plan: see 49201

Reviewed By: malfet

Differential Revision: D25717102

Pulled By: ilia-cher

fbshipit-source-id: 5e794a7f5fe160ca64ac9d190c4fd3e8f1e443e6
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#49201

This unblocks kineto profiler for 1.8 release.
This PR supercedes pytorch#48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13  2019 /usr/local/cuda/lib64/libcupti_static.a

Test Plan:
CI
pytorch#48391

Imported from OSS

Reviewed By: ngimel

Differential Revision: D25480770

fbshipit-source-id: 037cd774f5547d9918d6055ef5cc952a54e48e4c
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#49897

Resend of pytorch#49201

Test Plan: see 49201

Reviewed By: malfet

Differential Revision: D25717102

Pulled By: ilia-cher

fbshipit-source-id: 5e794a7f5fe160ca64ac9d190c4fd3e8f1e443e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants