Set USE_KINETO=1#49201
Closed
ilia-cher wants to merge 20 commits intogh/ilia-cher/90/basefrom
Closed
Conversation
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 10, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: de304c3 Pull Request resolved: #49201
Contributor
💊 CI failures summary and remediationsAs of commit 69d1d9a (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
malfet
approved these changes
Dec 11, 2020
Contributor
malfet
left a comment
There was a problem hiding this comment.
LGTM, but please do not merge this change unless CI is green after rebasing this PR against viable/strict
Closed
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 11, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: c146305 Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 11, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: 519eb14 Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 16, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: 51b014d Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 16, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: ba86754 Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 17, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: 6675142 Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Dec 17, 2020
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: ghstack-source-id: edca588 Pull Request resolved: #49201
Summary: This unblocks kineto profiler for 1.8 release. This PR supercedes #48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI #48391 TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1 BUILD_BINARY=1 python setup.py develop install --cmake python test/test_profiler.py python test/test_autograd.py -k test_profile python test/test_autograd.py -k test_record Reviewers:ngimel, robieta, nshulga Subscribers: Tasks: Tags: Differential Revision: [D25480770](https://our.internmc.facebook.com/intern/diff/D25480770) [ghstack-poisoned]
Contributor
|
|
Contributor
Author
|
had to revert because of ddp test failure, will resend |
Closed
ilia-cher
pushed a commit
that referenced
this pull request
Dec 28, 2020
Summary: Resend of #49201 Test Plan: see 49201 [ghstack-poisoned]
Contributor
Author
|
resending in #49897 |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Pull Request resolved: pytorch#49201 This unblocks kineto profiler for 1.8 release. This PR supercedes pytorch#48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI pytorch#48391 Imported from OSS Reviewed By: ngimel Differential Revision: D25480770 fbshipit-source-id: 037cd774f5547d9918d6055ef5cc952a54e48e4c
ilia-cher
pushed a commit
that referenced
this pull request
Jan 20, 2021
Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Jan 20, 2021
Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Jan 20, 2021
Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Jan 20, 2021
Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]
ilia-cher
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#49201 This unblocks kineto profiler for 1.8 release. This PR supercedes pytorch#48391 Note: this will somewhat increase the size of linux server binaries, bc we add libkineto.a and libcupti_static.a: -rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a -rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a Test Plan: CI pytorch#48391 Imported from OSS Reviewed By: ngimel Differential Revision: D25480770 fbshipit-source-id: 037cd774f5547d9918d6055ef5cc952a54e48e4c
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#49897 Resend of pytorch#49201 Test Plan: see 49201 Reviewed By: malfet Differential Revision: D25717102 Pulled By: ilia-cher fbshipit-source-id: 5e794a7f5fe160ca64ac9d190c4fd3e8f1e443e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This unblocks kineto profiler for 1.8 release.
This PR supercedes #48391
Note: this will somewhat increase the size of linux server binaries, bc
we add libkineto.a and libcupti_static.a:
-rw-r--r-- 1 jenkins jenkins 1107502 Dec 10 21:16 build/lib/libkineto.a
-rw-r--r-- 1 root root 13699658 Nov 13 2019 /usr/local/cuda/lib64/libcupti_static.a
Test Plan:
CI
#48391
TORCH_CUDA_ARCH_LIST="6.0;7.0" USE_CUDA=1 USE_MKLDNN=1
BUILD_BINARY=1 python setup.py develop install --cmake
python test/test_profiler.py
python test/test_autograd.py -k test_profile
python test/test_autograd.py -k test_record
Reviewers:ngimel, robieta, nshulga
Subscribers:
Tasks:
Tags:
Differential Revision: D25480770