Revert "torch.set_num_threads sets MKL option too"#4967
Merged
soumith merged 6 commits intopytorch:masterfrom Jan 31, 2018
Merged
Revert "torch.set_num_threads sets MKL option too"#4967soumith merged 6 commits intopytorch:masterfrom
soumith merged 6 commits intopytorch:masterfrom
Conversation
Contributor
|
Hey, why did you revert multiple other PRs? |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Revert "Clarify grad_input_mask documentation in derivatives.yaml (pytorch#4963)" This reverts commit 37c8454. * Revert "fix triu and tril for zero-strided inputs on gpu (pytorch#4962)" This reverts commit 9acb9be. * Revert "Add mutex for CPU RNG and move TH to C++ (pytorch#4041)" This reverts commit 07b7fe2. * Revert "Support multivariate TransformedDistributions (pytorch#4937)" This reverts commit 18bdb4a. * Revert "Only check that arguments are Variables in VariableType (pytorch#4943)" This reverts commit a479ca0. * Revert "torch.set_num_threads sets MKL option too (pytorch#4949)" This reverts commit 2cfb339.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4949
The recent addition of setting MKL num threads in torch.set_num_threads in multiprocessing on cuda CI machines causes segfaults. Our dataloader workers indeed do
torch.set_num_threads(1)before the loading loop. Let's revert this first to unblock the PRs.