Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl constructor#49470
Closed
SS-JIA wants to merge 5 commits intogh/SS-JIA/14/basefrom
Closed
Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl constructor#49470SS-JIA wants to merge 5 commits intogh/SS-JIA/14/basefrom
SS-JIA wants to merge 5 commits intogh/SS-JIA/14/basefrom
Conversation
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 98c6bf7 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
…Impl" [ghstack-poisoned]
Contributor
|
Not sure who the right person is to review this patch. The backstory is that we ran into runtime crashes on the Vulkan backend recently which Stephen has narrowed to #48625. |
Collaborator
|
Can you please add tests that would exercise codepaths previously leading to crashes? We are working on making TensorImpl more efficient, and unless you are testing for the behaviors you rely upon, it could lead to breakages in the future. |
#48625 changes the default contiguous settings for TensorImpl. Therefore, refresh_contiguous() should be called in OpaqueTensorImpl to get the correct settings. [ghstack-poisoned]
#48625 changes the default contiguous settings for TensorImpl. Therefore, refresh_contiguous() should be called in OpaqueTensorImpl to get the correct settings. [ghstack-poisoned]
Contributor
Author
|
As suggested, changed to just set the flag in the constructor. @xta0 may want to take a look at this as well, since OpaqueTensorImpl is also used by the Metal backend. |
Contributor
|
Yeah we are puzzled by why this was not caught by CI as well. Investigating. Thanks. |
… constructor" #48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl`. [ghstack-poisoned]
AshkanAliabadi
approved these changes
Dec 17, 2020
Contributor
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
pytorch#49470) Summary: Pull Request resolved: pytorch#49470 pytorch#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, add argument that can set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl` constructor. Test Plan: Imported from OSS Reviewed By: AshkanAliabadi Differential Revision: D25592826 Pulled By: SS-JIA fbshipit-source-id: e5d9de9a733875cb00c0546a3bc3271e5c6e23a3
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
pytorch#49470) Summary: Pull Request resolved: pytorch#49470 pytorch#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, add argument that can set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl` constructor. Test Plan: Imported from OSS Reviewed By: AshkanAliabadi Differential Revision: D25592826 Pulled By: SS-JIA fbshipit-source-id: e5d9de9a733875cb00c0546a3bc3271e5c6e23a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
#48625 changes the default contiguous settings for
TensorImplcausing the Vulkan backend to crash. Therefore, add argument that can setis_non_overlapping_and_dense_back to false forOpaqueTensorImplconstructor.Differential Revision: D25592826