Skip to content

[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to true#48625

Closed
swolchok wants to merge 6 commits intogh/swolchok/24/basefrom
gh/swolchok/24/head
Closed

[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to true#48625
swolchok wants to merge 6 commits intogh/swolchok/24/basefrom
gh/swolchok/24/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Nov 30, 2020 •
edited
Loading

Stack from ghstack:

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: D25232196

@swolchok
[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to…
2f1239a 
… true

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Nov 30, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Nov 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 47b2524 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 08 01:36:09  
Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Dec 08 01:36:09  
Dec 08 01:36:09 At: 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize 
Dec 08 01:36:09   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize 
Dec 08 01:36:09  
Dec 08 01:36:09 [W tensorpipe_agent.cpp:547] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Dec 08 01:36:10 ok (1.738s) 
Dec 08 01:36:11   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Dec 08 01:36:11 ok (1.736s) 
Dec 08 01:36:13   test_return_local_rrefs (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:547] RPC agent for worker3 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 63 times.

ngimel
ngimel approved these changes Nov 30, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@swolchok
Update on "[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should…
349c1db 
… default to true"

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should…
c8a5f79 
… default to true"

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should…
74ab7ef 
… default to true"

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Dec 3, 2020
@swolchok
[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to…
14139e3 
… true

Pull Request resolved: #48625

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().
ghstack-source-id: 117786248

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)
@swolchok
Update on "[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should…
fae09ad 
… default to true"

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
@swolchok
fix SparseTensorImpl on "[PyTorch] TensorImpl::is_non_overlapping_and…
47b2524 
…_dense_ should default to true"

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().

Differential Revision: [D25232196](https://our.internmc.facebook.com/intern/diff/D25232196/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 9, 2020

This pull request has been merged in a20d451.

@ailzhang ailzhang mentioned this pull request Dec 11, 2020
Merged
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/24/head branch December 12, 2020 15:21
@SS-JIA SS-JIA mentioned this pull request Dec 16, 2020
Closed
SS-JIA pushed a commit that referenced this pull request Dec 16, 2020
Update on "Call refresh_contiguous() in OpaqueTensorImpl constructor"
5021ee5 
#48625 changes the default contiguous settings for TensorImpl. Therefore, refresh_contiguous() should be called in OpaqueTensorImpl to get the correct settings.

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Dec 16, 2020
Update on "Call refresh_contiguous() in OpaqueTensorImpl constructor"
e7d4f3c 
#48625 changes the default contiguous settings for TensorImpl. Therefore, refresh_contiguous() should be called in OpaqueTensorImpl to get the correct settings.

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Dec 16, 2020
Update on "Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl…
98c6bf7 
… constructor"


#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl`.

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Dec 17, 2020
@facebook-github-bot
Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl constructor (
20b90f3 
#49470)

Summary:
Pull Request resolved: #49470

#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, add argument that can set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl` constructor.

Test Plan: Imported from OSS

Reviewed By: AshkanAliabadi

Differential Revision: D25592826

Pulled By: SS-JIA

fbshipit-source-id: e5d9de9a733875cb00c0546a3bc3271e5c6e23a3
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 6, 2021
Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl constructor (
83f6ad5 
pytorch#49470)

Summary:
Pull Request resolved: pytorch#49470

pytorch#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, add argument that can set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl` constructor.

Test Plan: Imported from OSS

Reviewed By: AshkanAliabadi

Differential Revision: D25592826

Pulled By: SS-JIA

fbshipit-source-id: e5d9de9a733875cb00c0546a3bc3271e5c6e23a3
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@swolchok @facebook-github-bot
[PyTorch] TensorImpl::is_non_overlapping_and_dense_ should default to…
57961f2 
… true (pytorch#48625)

Summary:
Pull Request resolved: pytorch#48625

The default TensorImpl is contiguous. Therefore, it is non-overlapping and dense per refresh_contiguous().
ghstack-source-id: 118035410

Test Plan: CI

Reviewed By: ezyang

Differential Revision: D25232196

fbshipit-source-id: 1968d9ed444f2ad5414a78d0b11e5d3030e3109d
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Set is_non_overlapping_and_dense_ flag in OpaqueTensorImpl constructor (
4f68104 
pytorch#49470)

Summary:
Pull Request resolved: pytorch#49470

pytorch#48625 changes the default contiguous settings for `TensorImpl` causing the Vulkan backend to crash. Therefore, add argument that can set `is_non_overlapping_and_dense_` back to false for `OpaqueTensorImpl` constructor.

Test Plan: Imported from OSS

Reviewed By: AshkanAliabadi

Differential Revision: D25592826

Pulled By: SS-JIA

fbshipit-source-id: e5d9de9a733875cb00c0546a3bc3271e5c6e23a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@smessmer smessmer Awaiting requested review from smessmer

+1 more reviewer

@bhosmer bhosmer bhosmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @facebook-github-bot @bhosmer @ngimel