third_party: Update pybind to point to fork#48120
Closed
seemethere wants to merge 1 commit intomasterfrom
Closed
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
walterddr
approved these changes
Nov 17, 2020
💊 CI failures summary and remediationsAs of commit 447e00c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 32 times. |
d99c272 to
4b76f9c
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
51f3606 to
6d2db4c
Compare
There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: 28d669e Pull Request resolved: #48117 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
6d2db4c to
447e00c
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #48120 +/- ##
==========================================
- Coverage 81.26% 81.25% -0.01%
==========================================
Files 1839 1839
Lines 198808 198808
==========================================
- Hits 161554 161547 -7
- Misses 37254 37261 +7 |
Contributor
|
@seemethere merged this pull request in aa8aa30. |
seemethere
added a commit
to seemethere/pytorch
that referenced
this pull request
Nov 20, 2020
Summary: There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#48117 Relates to: pybind/pybind11#2657 Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb Fixes pytorch#47776 Pull Request resolved: pytorch#48120 Reviewed By: gchanan Differential Revision: D25030688 Pulled By: seemethere fbshipit-source-id: 10889c813aeaa70ef1298adad5c631e6b5a39d72 (cherry picked from commit aa8aa30) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are specific patches we need for Python 3.9 compatibilty and that
process is currently hung up on separate issues.
Let's update to a newer version of our forked pybind to grab the Python
3.9 fixes while we wait for them to be upstreamed
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Relates to: pybind/pybind11#2657
Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb
Fixes #47776