third_party: Update pybind to point to fork by seemethere · Pull Request #48117 · pytorch/pytorch

seemethere · 2020-11-17T19:58:59Z

Stack from ghstack:

third_party: Update pybind to point to fork #48117 third_party: Update pybind to point to fork

There are specific patches we need for Python 3.9 compatabilty and that
process is currently hung up.

Let's update to a newer version of our forked pybind to grab the Python
3.9 fixes while we wait for them to be upstreamed

Relates to: pybind/pybind11#2657

Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb

Signed-off-by: Eli Uriegas eliuriegas@fb.com

There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]

There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: 28d669e Pull Request resolved: #48117

seemethere · 2020-11-17T20:21:30Z

Closing in favor of #48120 since ghstack doesn't support submodule updates

dr-ci · 2020-11-17T20:32:19Z

💊 CI failures summary and remediations

As of commit fbcc614 (more details on the Dr. CI page):

8/10 failures possibly* introduced in this PR
- 1/8 non-CircleCI failure(s)
2/10 broken upstream at merge base 315122c since Nov 17

🕵️ 7 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 20:59:42 ERROR 2020-11-17T20:56:24Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function ‘int main()’:\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:22: error: expected ‘;’ before ‘}’ token\n    2 | int main() { return 0 }\n      |                      ^~\n      |                      ;\n" }

Nov 17 20:59:42     raise RuntimeError(err_message) 
Nov 17 20:59:42 RuntimeError: test_cpp_extensions_jit failed! Received signal: SIGSEGV 
Nov 17 20:59:42  
Nov 17 20:59:42 real	5m25.560s 
Nov 17 20:59:42 user	0m19.526s 
Nov 17 20:59:42 sys	0m4.751s 
Nov 17 20:59:42 + cleanup 
Nov 17 20:59:42 + retcode=1 
Nov 17 20:59:42 + set +x 
Nov 17 20:59:42 =================== sccache compilation log =================== 
Nov 17 20:59:42 ERROR 2020-11-17T20:56:24Z: sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function ‘int main()’:\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:22: error: expected ‘;’ before ‘}’ token\n    2 | int main() { return 0 }\n      |                      ^~\n      |                      ;\n" } 
Nov 17 20:59:42  
Nov 17 20:59:42 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Nov 17 20:59:42 Compile requests                      56 
Nov 17 20:59:42 Compile requests executed             35 
Nov 17 20:59:42 Cache hits                             2 
Nov 17 20:59:42 Cache hits (C/C++)                     2 
Nov 17 20:59:42 Cache misses                          32 
Nov 17 20:59:42 Cache misses (C/C++)                  32 
Nov 17 20:59:42 Cache timeouts                         0 
Nov 17 20:59:42 Cache read errors                      0

pytorch_linux_bionic_py3_6_clang9_test (2/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 20:41:34 sccache: error: couldn't connect to server

Nov 17 20:41:34 +++ eval 'extract_trap_cmd ' 
Nov 17 20:41:34 ++++ extract_trap_cmd 
Nov 17 20:41:34 ++++ printf '%s\n' '' 
Nov 17 20:41:34 +++ printf '%s\n' cleanup 
Nov 17 20:41:34 ++ trap -- ' 
Nov 17 20:41:34 cleanup' EXIT 
Nov 17 20:41:34 ++ [[ pytorch-linux-bionic-py3.6-clang9-test != *pytorch-win-* ]] 
Nov 17 20:41:34 ++ which sccache 
Nov 17 20:41:34 ++ sccache --stop-server 
Nov 17 20:41:34 Stopping sccache server... 
Nov 17 20:41:34 sccache: error: couldn't connect to server 
Nov 17 20:41:34 sccache: caused by: Connection refused (os error 111) 
Nov 17 20:41:34 ++ true 
Nov 17 20:41:34 ++ rm /var/lib/jenkins/sccache_error.log 
Nov 17 20:41:34 ++ [[ pytorch-linux-bionic-py3.6-clang9-test == *rocm* ]] 
Nov 17 20:41:34 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Nov 17 20:41:34 ++ SCCACHE_IDLE_TIMEOUT=1200 
Nov 17 20:41:34 ++ RUST_LOG=sccache::server=error 
Nov 17 20:41:34 ++ sccache --start-server 
Nov 17 20:41:34 sccache: Starting the server... 
Nov 17 20:41:34 ++ sccache --zero-stats

pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (3/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 20:52:19 sccache: error: couldn't connect to server

Nov 17 20:52:19 +++ eval 'extract_trap_cmd ' 
Nov 17 20:52:19 ++++ extract_trap_cmd 
Nov 17 20:52:19 ++++ printf '%s\n' '' 
Nov 17 20:52:19 +++ printf '%s\n' cleanup 
Nov 17 20:52:19 ++ trap -- ' 
Nov 17 20:52:19 cleanup' EXIT 
Nov 17 20:52:19 ++ [[ pytorch-linux-bionic-py3.8-gcc9-coverage-test1 != *pytorch-win-* ]] 
Nov 17 20:52:19 ++ which sccache 
Nov 17 20:52:19 ++ sccache --stop-server 
Nov 17 20:52:19 Stopping sccache server... 
Nov 17 20:52:19 sccache: error: couldn't connect to server 
Nov 17 20:52:19 sccache: caused by: Connection refused (os error 111) 
Nov 17 20:52:19 ++ true 
Nov 17 20:52:19 ++ rm /var/lib/jenkins/sccache_error.log 
Nov 17 20:52:19 ++ [[ pytorch-linux-bionic-py3.8-gcc9-coverage-test1 == *rocm* ]] 
Nov 17 20:52:19 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Nov 17 20:52:19 ++ SCCACHE_IDLE_TIMEOUT=1200 
Nov 17 20:52:19 ++ RUST_LOG=sccache::server=error 
Nov 17 20:52:19 ++ sccache --start-server 
Nov 17 20:52:19 sccache: Starting the server... 
Nov 17 20:52:19 ++ sccache --zero-stats

pytorch_linux_xenial_py3_6_gcc5_4_test (4/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 21:43:34 [E request_callback_no_python.cpp:592] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future

Nov 17 21:43:34 At: 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 17 21:43:34  
Nov 17 21:43:34 [E request_callback_no_python.cpp:592] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Nov 17 21:43:34  
Nov 17 21:43:34 At: 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 17 21:43:34  
Nov 17 21:43:34 [E request_callback_no_python.cpp:592] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Nov 17 21:43:34  
Nov 17 21:43:34 At: 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 17 21:43:34   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 17 21:43:34  
Nov 17 21:43:34 [W tensorpipe_agent.cpp:504] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Nov 17 21:43:34 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 
Nov 17 21:43:34 [W tensorpipe_agent.cpp:504] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown) 
Nov 17 21:43:34 ok (1.943s) 
Nov 17 21:43:36   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:504] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)

pytorch_linux_xenial_py3_clang5_asan_test2 (5/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 20:50:25 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:13:3 in

Nov 17 20:50:25     #7 0x561e7cd3b70b in PyEval_EvalCode /tmp/build/80754af9/python_1599604603603/work/Python/ceval.c:731 
Nov 17 20:50:25     #8 0x561e7cdbb573 in run_mod /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:1025 
Nov 17 20:50:25     #9 0x561e7cdbb60c in PyRun_StringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:949 
Nov 17 20:50:25     #10 0x561e7cdbb66e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:445 
Nov 17 20:50:25     #11 0x561e7cdbf472 in run_command /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:301 
Nov 17 20:50:25     #12 0x561e7cdbf472 in Py_Main /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:749 
Nov 17 20:50:25     #13 0x561e7cc8943d in main /tmp/build/80754af9/python_1599604603603/work/Programs/python.c:69 
Nov 17 20:50:25     #14 0x7fd6134d183f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291 
Nov 17 20:50:25     #15 0x561e7cd68d0a in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
Nov 17 20:50:25  
Nov 17 20:50:25 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:13:3 in  
Nov 17 20:50:25 + retcode=1 
Nov 17 20:50:25 + set -e 
Nov 17 20:50:25 + return 1 
Nov 17 20:50:25 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX-* ]] 
Nov 17 20:50:25 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 == *-NO_AVX2-* ]] 
Nov 17 20:50:25 + '[' -n https://github.com/pytorch/pytorch/pull/48117 ']' 
Nov 17 20:50:25 + [[ pytorch-linux-xenial-py3-clang5-asan-test2 != *coverage* ]] 
Nov 17 20:50:25 ++ mktemp 
Nov 17 20:50:25 + DETERMINE_FROM=/tmp/tmp.kA6D5XZf2n 
Nov 17 20:50:25 + file_diff_from_base /tmp/tmp.kA6D5XZf2n

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (6/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 21:01:26 sccache: error: couldn't connect to server

Nov 17 21:01:26 +++ eval 'extract_trap_cmd ' 
Nov 17 21:01:26 ++++ extract_trap_cmd 
Nov 17 21:01:26 ++++ printf '%s\n' '' 
Nov 17 21:01:26 +++ printf '%s\n' cleanup 
Nov 17 21:01:26 ++ trap -- ' 
Nov 17 21:01:26 cleanup' EXIT 
Nov 17 21:01:26 ++ [[ pytorch-linux-xenial-cuda10.2-cudnn7-py3-gcc7-test2 != *pytorch-win-* ]] 
Nov 17 21:01:26 ++ which sccache 
Nov 17 21:01:26 ++ sccache --stop-server 
Nov 17 21:01:26 Stopping sccache server... 
Nov 17 21:01:26 sccache: error: couldn't connect to server 
Nov 17 21:01:26 sccache: caused by: Connection refused (os error 111) 
Nov 17 21:01:26 ++ true 
Nov 17 21:01:26 ++ rm /var/lib/jenkins/sccache_error.log 
Nov 17 21:01:26 ++ [[ pytorch-linux-xenial-cuda10.2-cudnn7-py3-gcc7-test2 == *rocm* ]] 
Nov 17 21:01:26 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log 
Nov 17 21:01:26 ++ SCCACHE_IDLE_TIMEOUT=1200 
Nov 17 21:01:26 ++ RUST_LOG=sccache::server=error 
Nov 17 21:01:26 ++ sccache --start-server 
Nov 17 21:01:26 sccache: Starting the server... 
Nov 17 21:01:26 ++ sccache --zero-stats

pytorch_linux_xenial_py3_clang5_asan_test1 (7/7)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 17 20:50:40 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:13:3 in

Nov 17 20:50:40     #7 0x55fd469bb70b in PyEval_EvalCode /tmp/build/80754af9/python_1599604603603/work/Python/ceval.c:731 
Nov 17 20:50:40     #8 0x55fd46a3b573 in run_mod /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:1025 
Nov 17 20:50:40     #9 0x55fd46a3b60c in PyRun_StringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:949 
Nov 17 20:50:40     #10 0x55fd46a3b66e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1599604603603/work/Python/pythonrun.c:445 
Nov 17 20:50:40     #11 0x55fd46a3f472 in run_command /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:301 
Nov 17 20:50:40     #12 0x55fd46a3f472 in Py_Main /tmp/build/80754af9/python_1599604603603/work/Modules/main.c:749 
Nov 17 20:50:40     #13 0x55fd4690943d in main /tmp/build/80754af9/python_1599604603603/work/Programs/python.c:69 
Nov 17 20:50:40     #14 0x7f4c8305983f in __libc_start_main /build/glibc-e6zv40/glibc-2.23/csu/../csu/libc-start.c:291 
Nov 17 20:50:40     #15 0x55fd469e8d0a in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
Nov 17 20:50:40  
Nov 17 20:50:40 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:13:3 in  
Nov 17 20:50:40 + retcode=1 
Nov 17 20:50:40 + set -e 
Nov 17 20:50:40 + return 1 
Nov 17 20:50:40 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX-* ]] 
Nov 17 20:50:40 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 == *-NO_AVX2-* ]] 
Nov 17 20:50:40 + '[' -n https://github.com/pytorch/pytorch/pull/48117 ']' 
Nov 17 20:50:40 + [[ pytorch-linux-xenial-py3-clang5-asan-test1 != *coverage* ]] 
Nov 17 20:50:40 ++ mktemp 
Nov 17 20:50:40 + DETERMINE_FROM=/tmp/tmp.5u3HW6a7Yh 
Nov 17 20:50:40 + file_diff_from_base /tmp/tmp.5u3HW6a7Yh

🚧 2 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet:

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 since Nov 17
- 🔁 rerun
pytorch_windows_vs2019_py36_cuda10.1_test2 since Nov 17
- 🔁 rerun

ci.pytorch.org: 1 failed

Failed: pr/pytorch-linux-bionic-rocm3.9-py3.6

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: 28d669e Pull Request resolved: #48117 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Summary: There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #48117 Relates to: pybind/pybind11#2657 Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb Fixes #47776 Pull Request resolved: #48120 Reviewed By: gchanan Differential Revision: D25030688 Pulled By: seemethere fbshipit-source-id: 10889c813aeaa70ef1298adad5c631e6b5a39d72

Summary: There are specific patches we need for Python 3.9 compatibilty and that process is currently hung up on separate issues. Let's update to a newer version of our forked pybind to grab the Python 3.9 fixes while we wait for them to be upstreamed Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#48117 Relates to: pybind/pybind11#2657 Full comparison for this update looks like this: pybind/pybind11@59a2ac2...seemethere:v2.6-fb Fixes pytorch#47776 Pull Request resolved: pytorch#48120 Reviewed By: gchanan Differential Revision: D25030688 Pulled By: seemethere fbshipit-source-id: 10889c813aeaa70ef1298adad5c631e6b5a39d72 (cherry picked from commit aa8aa30) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

facebook-github-bot added the cla signed label Nov 17, 2020

seemethere requested a review from a team November 17, 2020 20:01

seemethere added the module: pybind Related to our Python bindings / interactions with other Python libraries label Nov 17, 2020

walterddr approved these changes Nov 17, 2020

View reviewed changes

malfet approved these changes Nov 17, 2020

View reviewed changes

seemethere mentioned this pull request Nov 17, 2020

third_party: Update pybind to point to fork #48120

Closed

seemethere closed this Nov 17, 2020

This was referenced Nov 20, 2020

[v1.7.1] third_party: Update pybind to point to fork #48312

Merged

[v1.7.1] Release Tracker #47622

Closed

facebook-github-bot deleted the gh/seemethere/41/head branch December 18, 2020 15:21

ezyang mentioned this pull request Jan 4, 2021

Crash on exit in Python 3.9.0a6 #38230

Closed

This was referenced Jan 19, 2021

pybind11::gil_scoped_release: crash on exit with daemon threads #38228

Open

Segmentation Fault when killing uwsgi workers using PyTorch #42125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

third_party: Update pybind to point to fork#48117

third_party: Update pybind to point to fork#48117
seemethere wants to merge 1 commit intogh/seemethere/41/basefrom
gh/seemethere/41/head

seemethere commented Nov 17, 2020 •

edited

Loading

Uh oh!

seemethere commented Nov 17, 2020

Uh oh!

dr-ci bot commented Nov 17, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

seemethere commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seemethere commented Nov 17, 2020

Uh oh!

dr-ci bot commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 7 new failures recognized by patterns

pytorch_linux_bionic_py3_8_gcc9_coverage_test2 (1/7)

pytorch_linux_bionic_py3_6_clang9_test (2/7)

pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (3/7)

pytorch_linux_xenial_py3_6_gcc5_4_test (4/7)

pytorch_linux_xenial_py3_clang5_asan_test2 (5/7)

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (6/7)

pytorch_linux_xenial_py3_clang5_asan_test1 (7/7)

🚧 2 ongoing upstream failures:

ci.pytorch.org: 1 failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seemethere commented Nov 17, 2020 •

edited

Loading

dr-ci bot commented Nov 17, 2020 •

edited

Loading