Remove unnecessary byte-for-byte compatibility code that is not needed.#45975
Closed
ezyang wants to merge 4 commits intogh/ezyang/851/basefrom
Closed
Remove unnecessary byte-for-byte compatibility code that is not needed.#45975ezyang wants to merge 4 commits intogh/ezyang/851/basefrom
ezyang wants to merge 4 commits intogh/ezyang/851/basefrom
Conversation
I reordered declarations in the faithful API reimplementation to make sure the diffs lined up nicely; they're not necessary now. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
smessmer
approved these changes
Oct 9, 2020
…s not needed." I reordered declarations in the faithful API reimplementation to make sure the diffs lined up nicely; they're not necessary now. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/851/base #45975 +/- ##
======================================================
- Coverage 68.29% 68.28% -0.01%
======================================================
Files 410 410
Lines 53468 53468
======================================================
- Hits 36514 36513 -1
- Misses 16954 16955 +1
Continue to review full report at Codecov.
|
💊 CI failures summary and remediationsAs of commit 7abe7ba (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
…s not needed." I reordered declarations in the faithful API reimplementation to make sure the diffs lined up nicely; they're not necessary now. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24223102](https://our.internmc.facebook.com/intern/diff/D24223102) [ghstack-poisoned]
…s not needed." I reordered declarations in the faithful API reimplementation to make sure the diffs lined up nicely; they're not necessary now. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24223102](https://our.internmc.facebook.com/intern/diff/D24223102) [ghstack-poisoned]
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I reordered declarations in the faithful API reimplementation to
make sure the diffs lined up nicely; they're not necessary now.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D24223102