Closed
Conversation
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Oct 6, 2020
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 14355c1 Pull Request resolved: #45918
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/848/base #45918 +/- ##
===================================================
Coverage 68.28% 68.28%
===================================================
Files 410 410
Lines 53468 53468
===================================================
Hits 36513 36513
Misses 16955 16955 Continue to review full report at Codecov.
|
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Oct 7, 2020
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 0becbb3 Pull Request resolved: #45918
This was referenced Oct 7, 2020
smessmer
reviewed
Oct 9, 2020
|
|
||
| # Represents a bundle of native functions that are semantically related. | ||
| @dataclass(frozen=True) | ||
| class NativeFunctionGroup: |
Contributor
There was a problem hiding this comment.
A third concept we also name "group"?
Contributor
Author
There was a problem hiding this comment.
Second, really; after I got rid of grouped_arguments for packs in faithful C++ signature we are now just "group arguments" and "group native functions." IDK if you have a better name; in this case it seems less bad because the entity being grouped is different between the two cases.
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24163526](https://our.internmc.facebook.com/intern/diff/D24163526) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 33e3d04 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
smessmer
approved these changes
Oct 9, 2020
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24163526](https://our.internmc.facebook.com/intern/diff/D24163526) [ghstack-poisoned]
This groups together related native functions (functional, inplace, out) into a single group. It's not used by anything but Jiakai said this would be useful for his stuff so I'm putting it in immediately. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D24163526](https://our.internmc.facebook.com/intern/diff/D24163526) [ghstack-poisoned]
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This groups together related native functions (functional, inplace, out)
into a single group. It's not used by anything but Jiakai said this
would be useful for his stuff so I'm putting it in immediately.
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D24163526