Fix codegen/cuda gcc-5.4 compilation issues#43223
Fix codegen/cuda gcc-5.4 compilation issues#43223malfet wants to merge 1 commit intopytorch:masterfrom
codegen/cuda gcc-5.4 compilation issues#43223Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Might also be good to run this through a |
💊 CI failures summary and remediationsAs of commit c5e3550 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
1 failure confirmed as flaky and can be ignored:
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
|
Adding a Not trying to promote the other PR, I wasn't aware someone is fixing this when I issued that. |
e5ab414 to
169b8e0
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@seemethere, I've just applied this change manually in https://app.circleci.com/pipelines/github/pytorch/pytorch/201646/workflows/9ca92568-c081-4518-8977-9692d5f73602/jobs/6784578 |
Most of the fixes is the same old enum-is-not-hasheable error In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision This regression was introduced by pytorch#43129
169b8e0 to
c5e3550
Compare
|
Another update to fix linter errors |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
1 similar comment
Summary: Most of the fixes is the same old enum-is-not-hasheable error In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision This regression was introduced by pytorch/pytorch#43129 Pull Request resolved: pytorch/pytorch#43223 Reviewed By: albanD, seemethere Differential Revision: D23198330 Pulled By: malfet fbshipit-source-id: 576082f7a4454dd29182892c9c4e0b51a967d456
Summary: Most of the fixes is the same old enum-is-not-hasheable error In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision This regression was introduced by pytorch/pytorch#43129 Pull Request resolved: pytorch/pytorch#43223 Reviewed By: albanD, seemethere Differential Revision: D23198330 Pulled By: malfet fbshipit-source-id: 576082f7a4454dd29182892c9c4e0b51a967d456
Summary: Most of the fixes is the same old enum-is-not-hasheable error In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision This regression was introduced by pytorch#43129 Pull Request resolved: pytorch#43223 Reviewed By: albanD, seemethere Differential Revision: D23198330 Pulled By: malfet fbshipit-source-id: 576082f7a4454dd29182892c9c4e0b51a967d456
Most of the fixes is the same old enum-is-not-hasheable error
In manager.cpp use std::unordered_map::emplace rather than
insertto avoid error triggered by missed copy elisionThis regression was introduced by #43129