Skip to content

patch enum class as hash key for gcc 5.4#43222

Closed
jjsjann123 wants to merge 2 commits intopytorch:masterfrom
jjsjann123:GCC5_4_ENUM_CLASS_HASH_PATCH
Closed

patch enum class as hash key for gcc 5.4#43222
jjsjann123 wants to merge 2 commits intopytorch:masterfrom
jjsjann123:GCC5_4_ENUM_CLASS_HASH_PATCH

Conversation

@jjsjann123
Copy link
Copy Markdown
Collaborator

@jjsjann123 jjsjann123 commented Aug 18, 2020

Fixes #43129

where gcc doesn't support hash of enum class.

@jjsjann123 jjsjann123 requested review from csarofeen and ezyang August 18, 2020 20:27
@jjsjann123 jjsjann123 requested a review from apaszke as a code owner August 18, 2020 20:27
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 18, 2020
@jjsjann123 jjsjann123 mentioned this pull request Aug 18, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Aug 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit bea6449 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@jjsjann123 jjsjann123 mentioned this pull request Aug 18, 2020
Closed
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Aug 18, 2020

Looks good to me, although can you please guard it with #if defined(__GNUC__) \n #if __GNUC__ < 5
Also, please note that it does not fix all the GCC-5.4 regressions

@jjsjann123
Copy link
Copy Markdown
Collaborator Author

jjsjann123 commented Aug 18, 2020

Also, please note that it does not fix all the GCC-5.4 regressions

Wondering what are the other issues with gcc 5.4 that I missed?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 30, 2020

Hi @jjsjann123!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@jjsjann123 jjsjann123 closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@apaszke apaszke Awaiting requested review from apaszke

+1 more reviewer

@csarofeen csarofeen csarofeen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jjsjann123 @malfet @facebook-github-bot @csarofeen @pytorchbot