Pin VC++ version to 14.26 #43184
Conversation
Because mkldnn triggers internal compiler error with 16.7, see uxlfoundation/oneDNN#812
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 01b5dbf (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 12 times. |
|
@malfet The fix is working for PyTorch Windows builds. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I think this missed the binary job tests specified in here ? |
|
@albanD because we need to apply similar fix to https://github.com/pytorch/builder , this PR presumably should address both issues by switching to older windows images #43220 |
Summary: VC++14.27 fails to compile mkl-dnn, see uxlfoundation/oneDNN#812 Pull Request resolved: pytorch#43184 Reviewed By: glaringlee Differential Revision: D23181803 Pulled By: malfet fbshipit-source-id: 9861c6243673c775374d77d2f51b45a42791b475
VC++14.27 fails to compile mkl-dnn, see uxlfoundation/oneDNN#812