[CircleCI] Use canary images until VC++ 14.27 issue is resolved#43220
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
[CircleCI] Use canary images until VC++ 14.27 issue is resolved#43220malfet wants to merge 1 commit intopytorch:masterfrom
canary images until VC++ 14.27 issue is resolved#43220malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit da48872 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
albanD
reviewed
Aug 18, 2020
Collaborator
albanD
left a comment
There was a problem hiding this comment.
How will it actually error out?
Is it a property of the canary build?
568b483 to
da48872
Compare
Contributor
Author
|
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
peterjc123
approved these changes
Aug 19, 2020
seemethere
approved these changes
Aug 19, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#43220) Summary: Should fix binary build issue on Windows, and promptly error out if images are updated to a different version of VC++ Pull Request resolved: pytorch#43220 Reviewed By: ezyang Differential Revision: D23198530 Pulled By: malfet fbshipit-source-id: 0c80361ad7dcfb7aaffccc306b7d741671bedc11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix binary build issue on Windows, and promptly error out if images are updated to a different version of VC++