[quant][graphmode] Support conv*d_relu in traced models#39490
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/333/basefrom
Closed
[quant][graphmode] Support conv*d_relu in traced models#39490jerryzh168 wants to merge 8 commits intogh/jerryzh168/333/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/333/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit f94c209 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 16 times. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jun 5, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
| const PatternInfo nn_conv2d_nn_relu = PatternInfo::parse_from_str( | ||
| R"( | ||
| graph(%self, %input, %relu): | ||
| %first_module = match::module[name="Conv2d"](%self) |
Contributor
There was a problem hiding this comment.
Why is conv2d the exception here?
raghuramank100
approved these changes
Jun 6, 2020
Contributor
raghuramank100
left a comment
There was a problem hiding this comment.
Looks good, except for special casing of Conv2d.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21917117](https://our.internmc.facebook.com/intern/diff/D21917117) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 6d13b58. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#39490 Test Plan: Imported from OSS Differential Revision: D21917117 fbshipit-source-id: c96633aaaa347529cc1ca6ca1c982cfb04675ccf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ifin insert_observers #39615 [quant][graphmode] Fix a corner case in handlingifin insert_observersSummary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21917117