Expose VC_YEAR in Windows binary test jobs#38957
Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Closed
Expose VC_YEAR in Windows binary test jobs#38957peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit a2eff67 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
ezyang
approved these changes
May 26, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
May 26, 2020
Summary: This PR relies on #38957 and pytorch/builder#445. Tested with #38949 and #38956. Will need a rebase after the dependent commits go in Pull Request resolved: #38959 Differential Revision: D21732423 Pulled By: malfet fbshipit-source-id: 50837a026a575bb3d547526e299db7bcfd7637a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it configurable in pytorch/builder#445.