Migrate Windows build jobs to VS 2019 for CUDA >= 10.1#38959
Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Closed
Migrate Windows build jobs to VS 2019 for CUDA >= 10.1#38959peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit 3331d8d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
ezyang
approved these changes
May 26, 2020
Contributor
|
@peterjc123 the Windows binary windows build failures look legit? |
Collaborator
Author
|
@ezyang It depends on #38957 and pytorch/builder#445. Will need a rebase after merging those two PRs. |
malfet
approved these changes
May 26, 2020
Contributor
|
Tests looks green after pytorch/builder#445 has been merged. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relies on #38957 and pytorch/builder#445.
Tested with #38949 and #38956.
Will need a rebase after the dependent commits go in