Skip to content

[JIT] Factor out aliases to separate test#38746

Closed
eellison wants to merge 4 commits intogh/eellison/81/basefrom
gh/eellison/81/head
Closed

[JIT] Factor out aliases to separate test#38746
eellison wants to merge 4 commits intogh/eellison/81/basefrom
gh/eellison/81/head

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented May 20, 2020

Stack from ghstack:

Factors out testing of op alias normalization so that there is a registry used for tests.

Differential Revision: D21673107

eellison pushed a commit that referenced this pull request May 20, 2020
ghstack-source-id: 49d5ce4
Pull Request resolved: #38746
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 20, 2020
@eellison eellison changed the title Factor out aliases to separate test [JIT] Factor out aliases to separate test May 20, 2020
@eellison eellison requested a review from mruberry May 20, 2020 00:09
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 20, 2020

💊 CI failures summary and remediations

As of commit b8616b6 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 21 00:48:15 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n ^\n" }
May 21 00:48:15 Traceback (most recent call last): 
May 21 00:48:15   File "test/run_test.py", line 691, in <module> 
May 21 00:48:15     main() 
May 21 00:48:15   File "test/run_test.py", line 684, in main 
May 21 00:48:15     raise RuntimeError(message) 
May 21 00:48:15 RuntimeError: test_utils failed! 
May 21 00:48:15 =================== sccache compilation log =================== 
May 21 00:48:15 + cleanup 
May 21 00:48:15 + retcode=1 
May 21 00:48:15 + set +x 
May 21 00:48:15 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
May 21 00:48:15  
May 21 00:48:15 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 21 00:48:15 Compile requests                 68 
May 21 00:48:15 Compile requests executed        35 
May 21 00:48:15 Cache hits                        4 
May 21 00:48:15 Cache misses                     30 
May 21 00:48:15 Cache timeouts                    0 
May 21 00:48:15 Cache read errors                 0 
May 21 00:48:15 Forced recaches                   0 
May 21 00:48:15 Cache write errors                0 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 21 times.

Factors out testing of op alias normalization so that there is a registry used for tests.

[ghstack-poisoned]
@eellison eellison requested review from bhosmer and jamesr66a May 20, 2020 17:50
Factors out testing of op alias normalization so that there is a registry used for tests.

[ghstack-poisoned]
eellison pushed a commit that referenced this pull request May 20, 2020
ghstack-source-id: 5878562
Pull Request resolved: #38746
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Factors out testing of op alias normalization so that there is a registry used for tests.

[ghstack-poisoned]
eellison pushed a commit that referenced this pull request May 20, 2020
ghstack-source-id: 7f130f8
Pull Request resolved: #38746
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@eellison merged this pull request in cd5d7a3.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/81/head branch May 25, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#38746

Factors out testing of op alias normalization so that there is a registry used for tests.

Test Plan: Imported from OSS

Differential Revision: D21673107

Pulled By: eellison

fbshipit-source-id: e06653cdf24f14a4253dd054e4d402d171d16a11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants