Skip to content

[JIT] Rename canonicalize ops#38734

Closed
eellison wants to merge 3 commits intogh/eellison/79/basefrom
gh/eellison/79/head
Closed

[JIT] Rename canonicalize ops#38734
eellison wants to merge 3 commits intogh/eellison/79/basefrom
gh/eellison/79/head

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented May 19, 2020

Stack from ghstack:

As far as I can tell, this pass only exists to canonicalize ops that are generating in the graph fuser, so it's kind of a misnomer.

Differential Revision: D21673109

[ghstack-poisoned]
@eellison eellison requested a review from apaszke as a code owner May 19, 2020 19:44
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 19, 2020
@eellison eellison requested a review from jamesr66a May 19, 2020 19:47
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 19, 2020

💊 CI failures summary and remediations

As of commit b577d96 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

eellison added 2 commits May 20, 2020 10:32
As far as I can tell, this pass only exists to canonicalize ops that are generating in the graph fuser, so it's kind of a misnomer.

[ghstack-poisoned]
As far as I can tell, this pass only exists to canonicalize ops that are generating in the graph fuser, so it's kind of a misnomer.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@eellison merged this pull request in 5183e3a.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/79/head branch May 25, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#38734

As far as I can tell, this pass only exists to canonicalize ops that are generating in the graph fuser, so it's kind of a misnomer.

Test Plan: Imported from OSS

Differential Revision: D21673109

Pulled By: eellison

fbshipit-source-id: b7bedf34ccaf1fcd442bfb2bbb990e64915f51d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants