Skip to content

Avoid double dispatch in logical_not for compilation speed reasons.#38565

Closed
gchanan wants to merge 3 commits intogh/gchanan/281/basefrom
gh/gchanan/281/head
Closed

Avoid double dispatch in logical_not for compilation speed reasons.#38565
gchanan wants to merge 3 commits intogh/gchanan/281/basefrom
gh/gchanan/281/head

Conversation

@gchanan
Copy link
Copy Markdown
Contributor

@gchanan gchanan commented May 15, 2020 •
edited
Loading

Stack from ghstack:

Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

Differential Revision: D21598478

@gchanan
Avoid double dispatch in logical_not for compilation speed reasons.
7809940 
Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 9851d69 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 15 22:34:50 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
May 15 22:34:50 processing existing schema:  aten::std.dim(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor) 
May 15 22:34:50 processing existing schema:  aten::std.out(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False, *, Tensor(a!) out) -> (Tensor(a!)) 
May 15 22:34:50 processing existing schema:  aten::std.names_dim(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor) 
May 15 22:34:50 processing existing schema:  aten::std.names_out(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False, *, Tensor(a!) out) -> (Tensor(a!)) 
May 15 22:34:50 processing existing schema:  aten::std_mean(Tensor self, bool unbiased=True) -> (Tensor, Tensor) 
May 15 22:34:50 processing existing schema:  aten::std_mean.dim(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 15 22:34:50 processing existing schema:  aten::std_mean.names_dim(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 15 22:34:50 processing existing schema:  aten::t(Tensor(a) self) -> (Tensor(a)) 
May 15 22:34:50 processing existing schema:  aten::t_(Tensor(a!) self) -> (Tensor(a!)) 
May 15 22:34:50 processing existing schema:  aten::tan_(Tensor(a!) self) -> (Tensor(a!)) 
May 15 22:34:50 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
May 15 22:34:50  
May 15 22:34:50 Broken ops: [ 
May 15 22:34:50 	profiler::_call_end_callbacks_on_jit_fut(Tensor x, Future(t) y) -> (Future(t)) 
May 15 22:34:50 ] 
May 15 22:34:50 + cleanup 
May 15 22:34:50 + retcode=1 
May 15 22:34:50 + set +x 
May 15 22:34:50 =================== sccache compilation log =================== 
May 15 22:34:50 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 15 22:34:50 Compile requests                 0

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 10 times.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 15, 2020

💊 CI failures summary and remediations

As of commit 7809940 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_windows_vs2019_py36_cpu_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

AssertionError: 7310574887148527616 not less than or equal to 0 : 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 234, in instantiated_test 
    result = test(self, device_arg, dtype) 
  File "test_torch.py", line 6458, in test_logical_not_out 
    self.assertEqual(out_np, out.to('cpu')) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1027, in assertEqual 
    allow_inf=allow_inf, exact_dtype=exact_dtype) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 930, in assertEqual 
    allow_inf=allow_inf, exact_dtype=exact_dtype) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1037, in assertEqual 
    super().assertLessEqual(abs(x - y), atol, message) 
AssertionError: 7310574887148527616 not less than or equal to 0 :  
 
---------------------------------------------------------------------- 
Ran 2302 tests in 93.151s 
 
FAILED (failures=57, skipped=139) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestTensorDeviceOpsCPU-20200515193108.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTorch-20200515193108.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTorchDeviceTypeCPU-20200515193108.xml
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

gchanan added 2 commits May 15, 2020 14:21
@gchanan
Update on "Avoid double dispatch in logical_not for compilation speed…
91c30b2 
… reasons."

Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

Differential Revision: [D21598478](https://our.internmc.facebook.com/intern/diff/D21598478)

[ghstack-poisoned]
@gchanan
Update on "Avoid double dispatch in logical_not for compilation speed…
9851d69 
… reasons."

Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

Differential Revision: [D21598478](https://our.internmc.facebook.com/intern/diff/D21598478)

[ghstack-poisoned]
gchanan added a commit that referenced this pull request May 15, 2020
@gchanan
Avoid double dispatch in logical_not for compilation speed reasons.
4d25ed9 
Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

ghstack-source-id: 9412b7c
Pull Request resolved: #38565
@gchanan gchanan requested a review from mruberry May 15, 2020 21:23
@gchanan gchanan mentioned this pull request May 15, 2020
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 18, 2020

@gchanan merged this pull request in b27be3e.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/281/head branch May 22, 2020 14:16
@peterbell10 peterbell10 mentioned this pull request Aug 20, 2020
Closed
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@gchanan @facebook-github-bot
Avoid double dispatch in logical_not for compilation speed reasons. (p…
a8c13e3 
…ytorch#38565)

Summary:
Pull Request resolved: pytorch#38565

Also note this turns on "-Wno-unused-local-typedefs" because we are using dispatch macros for error checking.

Test Plan: Imported from OSS

Differential Revision: D21598478

Pulled By: gchanan

fbshipit-source-id: 28f9ad01bd678df0601a10d0daf3ed31c47c4ab2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gchanan @facebook-github-bot @mruberry