Improve testing of logical_not.#38505
Closed
gchanan wants to merge 1 commit intogh/gchanan/280/basefrom
Closed
Conversation
This takes the testing of #38275, but doesn't include the kernel changes which are still being worked out. [ghstack-poisoned]
Contributor
|
NumPy seems now to be in requirements. So I wonder if |
💊 CI failures summary and remediationsAs of commit cfd76be (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
Author
|
that's a good question, I don't really know. @mruberry do you know? |
Collaborator
It looks like we will be OK taking a NumPy dependency in the tests, but let's leave the skips for now. |
mruberry
approved these changes
May 15, 2020
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
A million times better! Also a good candidate for torch.testing.fixture when that's in.
This was referenced May 15, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38505 This takes the testing of pytorch#38275, but doesn't include the kernel changes which are still being worked out. Test Plan: Imported from OSS Reviewed By: mruberry Differential Revision: D21580574 Pulled By: gchanan fbshipit-source-id: f12317259cb7373989f6c9ad345b19aaac524851
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This takes the testing of #38275, but doesn't include the kernel changes which are still being worked out.
Differential Revision: D21580574