[quant][graphmode] Add support for quantized conv1d + relu fusion#38441
Closed
supriyar wants to merge 4 commits intogh/supriyar/120/basefrom
Closed
[quant][graphmode] Add support for quantized conv1d + relu fusion#38441supriyar wants to merge 4 commits intogh/supriyar/120/basefrom
supriyar wants to merge 4 commits intogh/supriyar/120/basefrom
Conversation
Summary: Test Plan: python test/test_quantization.py test_quantized_conv1d_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 13, 2020
💊 CI failures summary and remediationsAs of commit 97e4760 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 17 times. |
| // aten::conv1d - aten::relu | ||
| std::string conv1d_relu = R"( | ||
| graph(%a_quant, %packed_params, %r_scale, %r_zero_point, %r_dtype, %stride, %padding, %dilation, %groups): | ||
| %a_dequant = aten::dequantize(%a_quant) |
Contributor
There was a problem hiding this comment.
For my understanding, where is the pack op inserted for the weights? I was expecting to see a wt->q->pack->unpack->dq->Conv
Contributor
There was a problem hiding this comment.
yes, it's inserted before, here we just fuse unpack - dq - conv - q to quantized::conv2d
raghuramank100
approved these changes
May 13, 2020
jerryzh168
reviewed
May 13, 2020
| // These are the IR patterns we match to skip inserting observers. | ||
| // They are compiled once on construction and used repeatedly within | ||
| // the pass. | ||
| const PatternInfo conv1d_functional_relu = PatternInfo::parse_from_str(R"( |
Contributor
There was a problem hiding this comment.
let's use naming convention suggested by @z-a-f : nn_conv1d_f_relu, similar for others
… fusion" Summary: Test Plan: python test/test_quantization.py test_quantized_conv1d_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
… fusion" Summary: Test Plan: python test/test_quantization.py test_quantized_conv1d_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
… fusion" Summary: Test Plan: python test/test_quantization.py test_quantized_conv1d_relu Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
|
This pull request has been merged in 8e73251. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#38441) Summary: Pull Request resolved: pytorch#38441 Test Plan: python test/test_quantization.py test_quantized_conv1d_relu Imported from OSS Differential Revision: D21575919 fbshipit-source-id: d43e33052ce1be5e38acef8fac16f22cb11c0695
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
python test/test_quantization.py test_quantized_conv1d_relu
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21575919