Skip to content

[quant] Support for fused ConvBn1d and ConvBnRelu1d modules#38452

Closed
supriyar wants to merge 6 commits intogh/supriyar/122/basefrom
gh/supriyar/122/head
Closed

[quant] Support for fused ConvBn1d and ConvBnRelu1d modules#38452
supriyar wants to merge 6 commits intogh/supriyar/122/basefrom
gh/supriyar/122/head

Conversation

@supriyar
Copy link
Copy Markdown
Contributor

@supriyar supriyar commented May 14, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21632878

@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules
5e060a1 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar supriyar requested a review from apaszke as a code owner May 14, 2020 01:08
This was referenced May 14, 2020
Closed
Closed
Closed
Closed
@supriyar
Update on "[quant] Support for fused ConvBn1d and ConvBnRelu1d modules"
eb3a3c7 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request May 14, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules
de4ae1c 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ce16586
Pull Request resolved: #38452
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 14, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0664c61 (more details on the Dr. CI page):

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 19 02:11:13 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n ^\n" } 
May 19 02:11:12     raise RuntimeError(message) 
May 19 02:11:12 RuntimeError: test_type_hints failed! 
May 19 02:11:13  
May 19 02:11:13 real	18m5.239s 
May 19 02:11:13 user	20m58.000s 
May 19 02:11:13 sys	2m3.260s 
May 19 02:11:13 + cleanup 
May 19 02:11:13 + retcode=1 
May 19 02:11:13 + set +x 
May 19 02:11:13 =================== sccache compilation log =================== 
May 19 02:11:13 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
May 19 02:11:13  
May 19 02:11:13 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 19 02:11:13 Compile requests                 64 
May 19 02:11:13 Compile requests executed        35 
May 19 02:11:13 Cache hits                       27 
May 19 02:11:13 Cache misses                      7 
May 19 02:11:13 Cache timeouts                    0 
May 19 02:11:13 Cache read errors                 0 
May 19 02:11:13 Forced recaches                   0 
May 19 02:11:13 Cache write errors                0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (2/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 19 02:16:22 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n ^\n" } 
May 19 02:16:22 Traceback (most recent call last): 
May 19 02:16:22   File "test/run_test.py", line 690, in <module> 
May 19 02:16:22     main() 
May 19 02:16:22   File "test/run_test.py", line 683, in main 
May 19 02:16:22     raise RuntimeError(message) 
May 19 02:16:22 RuntimeError: test_type_hints failed! 
May 19 02:16:22 + cleanup 
May 19 02:16:22 + retcode=1 
May 19 02:16:22 + set +x 
May 19 02:16:22 =================== sccache compilation log =================== 
May 19 02:16:22 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/var/lib/jenkins/.cache/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
May 19 02:16:22  
May 19 02:16:22 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 19 02:16:22 Compile requests                 64 
May 19 02:16:22 Compile requests executed        35 
May 19 02:16:22 Cache hits                       27 
May 19 02:16:22 Cache misses                      7 
May 19 02:16:22 Cache timeouts                    0 
May 19 02:16:22 Cache read errors                 0 
May 19 02:16:22 Forced recaches                   0 
May 19 02:16:22 Cache write errors                0

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test (3/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 19 01:59:46 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in 
May 19 01:59:46     #7 0x559c22cfc74b in PyEval_EvalCode /tmp/build/80754af9/python_1585002248360/work/Python/ceval.c:731 
May 19 01:59:46     #8 0x559c22d7c633 in run_mod /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:1025 
May 19 01:59:46     #9 0x559c22d7c6cc in PyRun_StringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:949 
May 19 01:59:46     #10 0x559c22d7c72e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:445 
May 19 01:59:46     #11 0x559c22d80532 in run_command /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:301 
May 19 01:59:46     #12 0x559c22d80532 in Py_Main /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:749 
May 19 01:59:46     #13 0x559c22c4b1fd in main /tmp/build/80754af9/python_1585002248360/work/Programs/python.c:69 
May 19 01:59:46     #14 0x7f07da67f82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291 
May 19 01:59:46     #15 0x559c22d29c29 in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
May 19 01:59:46  
May 19 01:59:46 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in  
May 19 01:59:46 + retcode=1 
May 19 01:59:46 + set -e 
May 19 01:59:46 + return 1 
May 19 01:59:46 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX-* ]] 
May 19 01:59:46 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX2-* ]] 
May 19 01:59:46 + '[' -n https://github.com/pytorch/pytorch/pull/38452 ']' 
May 19 01:59:46 ++ mktemp 
May 19 01:59:46 + DETERMINE_FROM=/tmp/tmp.DZsella3sT 
May 19 01:59:46 + file_diff_from_base /tmp/tmp.DZsella3sT 
May 19 01:59:46 + set +e

❄️ 2 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (1/2)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

gpg: no valid OpenPGP data found. 
+ curl -s -L --retry 3 https://nvidia.github.io/nvidia-docker/gpgkey 
+ sudo apt-key add - 
gpg: no valid OpenPGP data found.

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

May 19 02:41:12 ConnectionResetError: [Errno 104] Connection reset by peer 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 493, in Client 
May 19 02:41:12     answer_challenge(c, authkey) 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 737, in answer_challenge 
May 19 02:41:12     response = connection.recv_bytes(256)        # reject large message 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
May 19 02:41:12     buf = self._recv_bytes(maxlength) 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
May 19 02:41:12     buf = self._recv(4) 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
May 19 02:41:12     chunk = read(handle, remaining) 
May 19 02:41:12 ConnectionResetError: [Errno 104] Connection reset by peer 
May 19 02:41:12  
May 19 02:41:12 Process ErrorTrackingProcess-120: 
May 19 02:41:12 Traceback (most recent call last): 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
May 19 02:41:12     self.run() 
May 19 02:41:12   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 362, in run 
May 19 02:41:12     super(ErrorTrackingProcess, self).run() 
May 19 02:41:12   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
May 19 02:41:12     self._target(*self._args, **self._kwargs) 
May 19 02:41:12   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 630, in _test_proper_exit

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 28 times.

@supriyar
Update on "[quant] Support for fused ConvBn1d and ConvBnRelu1d modules"
66489cb 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request May 14, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules
65ba6e9 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 9b6c8d2
Pull Request resolved: #38452
raghuramank100
raghuramank100 reviewed May 15, 2020
View reviewed changes
Comment thread torch/quantization/fuse_modules.py Outdated
raghuramank100
raghuramank100 reviewed May 16, 2020
View reviewed changes
Comment thread torch/quantization/fuse_modules.py Outdated
raghuramank100
raghuramank100 reviewed May 16, 2020
View reviewed changes
Comment thread torch/testing/_internal/common_quantization.py Outdated
self.bn2 = nn.BatchNorm3d(2).to(dtype=torch.float)
self.relu3 = nn.ReLU(inplace=True).to(dtype=torch.float)
self.conv3 = nn.Conv1d(3, 3, 2).to(dtype=torch.float)
if train:
Copy link
Copy Markdown
Contributor

@raghuramank100 raghuramank100 May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead check that the code raises an exception for Conv1d + Bn1d and remove the train flag for the model?

raghuramank100
raghuramank100 reviewed May 16, 2020
View reviewed changes
Comment thread test/quantization/test_quantize.py Outdated
@supriyar
Update on "[quant] Support for fused ConvBn1d and ConvBnRelu1d modules"
15748e4 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request May 18, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules
a5202bf 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 7426b23
Pull Request resolved: #38452
@supriyar supriyar requested a review from raghuramank100 May 18, 2020 19:53
@supriyar
Update on "[quant] Support for fused ConvBn1d and ConvBnRelu1d modules"
a9f3f04 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar
Update on "[quant] Support for fused ConvBn1d and ConvBnRelu1d modules"
0664c61 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21632878](https://our.internmc.facebook.com/intern/diff/D21632878)

[ghstack-poisoned]
supriyar added a commit that referenced this pull request May 19, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules
b797b3b 
Summary:

Test Plan:
python test/test_quantization.py TestFused

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 10a1b8a
Pull Request resolved: #38452
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 19, 2020

This pull request has been merged in 7d38db0.

supriyar added a commit that referenced this pull request May 20, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (#38452)
cc63899 
Summary: Pull Request resolved: #38452

Test Plan:
python test/test_quantization.py TestFused
ghstack-source-id: dbeea36
supriyar added a commit that referenced this pull request May 20, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (#38452)
78eee1d 
Summary:

Test Plan:
python test/test_quantization.py TestFused

[ghstack-poisoned]
@supriyar supriyar mentioned this pull request May 20, 2020
Closed
supriyar added a commit that referenced this pull request May 20, 2020
@supriyar
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (#38452)
1000971 
Summary:

Test Plan:
python test/test_quantization.py TestFused

ghstack-source-id: dbeea36
Pull Request resolved: #38749
facebook-github-bot pushed a commit that referenced this pull request May 20, 2020
@supriyar @facebook-github-bot
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (#38452) (#…
530d48e 
…38749)

Summary: Pull Request resolved: #38749

Test Plan: python test/test_quantization.py TestFused

Differential Revision: D21654659

Pulled By: supriyar

fbshipit-source-id: 301be24083e794f4e71ff1d6d842e1aaefa640f0
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@supriyar @facebook-github-bot
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (pytorch#…
5c85680 
…38452)

Summary: Pull Request resolved: pytorch#38452

Test Plan:
python test/test_quantization.py TestFused

Imported from OSS

Differential Revision: D21632878

fbshipit-source-id: 0d73398b95d72a0a23b42ef36f3ede1bfcc35eda
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@supriyar @facebook-github-bot
[quant] Support for fused ConvBn1d and ConvBnRelu1d modules (pytorch#…
b285d95 
…38452) (pytorch#38749)

Summary: Pull Request resolved: pytorch#38749

Test Plan: python test/test_quantization.py TestFused

Differential Revision: D21654659

Pulled By: supriyar

fbshipit-source-id: 301be24083e794f4e71ff1d6d842e1aaefa640f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@supriyar @facebook-github-bot @raghuramank100 @mruberry