Skip to content

[quant] Add quantized::conv1d op benchmarck#38332

Closed
supriyar wants to merge 2 commits intogh/supriyar/116/basefrom
gh/supriyar/116/head
Closed

[quant] Add quantized::conv1d op benchmarck#38332
supriyar wants to merge 2 commits intogh/supriyar/116/basefrom
gh/supriyar/116/head

Conversation

@supriyar
Copy link
Copy Markdown
Contributor

@supriyar supriyar commented May 12, 2020

Stack from ghstack:

Summary:

Test Plan:

python -m pt.qconv_test --test QConv1d_N1_IC128_OC256_L64_G1_kernel3_stride1_pad0
Forward Execution Time (us) : 147.844

python -m pt.conv_test --test Conv1d_IC128_OC256_kernel3_stride1_N1_L64_cpu
Forward Execution Time (us) : 470.750

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21553662

Summary:

Test Plan:

python -m pt.qconv_test --test QConv1d_N1_IC128_OC256_L64_G1_kernel3_stride1_pad0
Forward Execution Time (us) : 147.844

python -m pt.conv_test --test Conv1d_IC128_OC256_kernel3_stride1_N1_L64_cpu
Forward Execution Time (us) : 470.750

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request May 12, 2020
Summary:

Test Plan:

python -m pt.qconv_test --test QConv1d_N1_IC128_OC256_L64_G1_kernel3_stride1_pad0
Forward Execution Time (us) : 147.844

python -m pt.conv_test --test Conv1d_IC128_OC256_kernel3_stride1_N1_L64_cpu
Forward Execution Time (us) : 470.750

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1daa3cb
Pull Request resolved: #38332
@supriyar supriyar requested review from raghuramank100 and vkuzo May 12, 2020 17:40
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 12, 2020

💊 CI failures summary and remediations

As of commit 6788596 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 4 times.

@supriyar supriyar requested a review from jerryzh168 May 12, 2020 20:47
tags=["resnext101_32x4d"],
)

class QConv1dBenchmark(op_bench.TorchBenchmarkBase):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we factor out the common part of this class so that future support is easier? e.g. we might want conv3d benchmark as well.

Summary:

Test Plan:

python -m pt.qconv_test --test QConv1d_N1_IC128_OC256_L64_G1_kernel3_stride1_pad0
Forward Execution Time (us) : 147.844

python -m pt.conv_test --test Conv1d_IC128_OC256_kernel3_stride1_N1_L64_cpu
Forward Execution Time (us) : 470.750

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in ae11718.

@facebook-github-bot facebook-github-bot deleted the gh/supriyar/116/head branch May 17, 2020 14:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#38332

Test Plan:
python -m pt.qconv_test --test QConv1d_N1_IC128_OC256_L64_G1_kernel3_stride1_pad0
Forward Execution Time (us) : 147.844

python -m pt.conv_test --test Conv1d_IC128_OC256_kernel3_stride1_N1_L64_cpu
Forward Execution Time (us) : 470.750

Imported from OSS

Differential Revision: D21553662

fbshipit-source-id: 9c240a141f9cd3a82a20aa462e8e5577e002a387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants