Remove ONNX BatchNorm(12) test and converter.#37309
Closed
codemzs wants to merge 3 commits intopytorch:masterfrom
Closed
Remove ONNX BatchNorm(12) test and converter.#37309codemzs wants to merge 3 commits intopytorch:masterfrom
codemzs wants to merge 3 commits intopytorch:masterfrom
Conversation
💊 Build failures summary and remediationsAs of commit 3e2cf40 (more details on the Dr. CI page):
1 failure not recognized by patterns:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 9 times. |
Contributor
Author
|
@houseroad can you please review this? |
lara-hdr
approved these changes
Apr 27, 2020
Contributor
lara-hdr
left a comment
There was a problem hiding this comment.
@houseroad BatchNorm was reverted from ONNX opset 12.
Could you please merge this change? thanks
…ve_batchnorm_12_onnx_test # Conflicts: # test/onnx/expect/TestOperators.test_batchnorm_training_opset12.expect
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
approved these changes
Apr 28, 2020
Contributor
Author
|
@houseroad Thank you very much for reviewing and merging my PR! |
Contributor
|
@houseroad merged this pull request in 6c0f447. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pursuant to onnx/onnx#2750 we must remove PyTorch ONNX exporter related changes to BatchNorm(12) that were introduced as part of pytorch#35567. This change is also needed to unblock ONNX [BUILD CI failures](https://circleci.com/gh/onnx/onnx/4629?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) caused by PyTorch/Caffe2 tests. Pull Request resolved: pytorch#37309 Reviewed By: hl475 Differential Revision: D21288914 Pulled By: houseroad fbshipit-source-id: 15b076a2af55918dcd57f4e2fc77accd3d1510bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuant to onnx/onnx#2750 we must remove PyTorch ONNX exporter related changes to BatchNorm(12) that were introduced as part of #35567. This change is also needed to unblock ONNX BUILD CI failures caused by PyTorch/Caffe2 tests.