Revert BatchNormalization(12)#2750
Merged
prasanthpul merged 5 commits intoonnx:masterfrom Apr 29, 2020
Merged
Conversation
This reverts commit 7114527. # Conflicts: # onnx/defs/nn/defs.cc
Closed
Contributor
Author
|
This PR depends on pytorch/pytorch#37309 that is causing CI failure with Caffe2 tests not being able to find BatchNorm(12) CC: @houseroad |
wschin
approved these changes
Apr 27, 2020
gramalingam
approved these changes
Apr 27, 2020
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 29, 2020
Summary: Pursuant to onnx/onnx#2750 we must remove PyTorch ONNX exporter related changes to BatchNorm(12) that were introduced as part of #35567. This change is also needed to unblock ONNX [BUILD CI failures](https://circleci.com/gh/onnx/onnx/4629?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) caused by PyTorch/Caffe2 tests. Pull Request resolved: #37309 Reviewed By: hl475 Differential Revision: D21288914 Pulled By: houseroad fbshipit-source-id: 15b076a2af55918dcd57f4e2fc77accd3d1510bd
3cfad1f to
8b8aa81
Compare
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pursuant to onnx/onnx#2750 we must remove PyTorch ONNX exporter related changes to BatchNorm(12) that were introduced as part of pytorch#35567. This change is also needed to unblock ONNX [BUILD CI failures](https://circleci.com/gh/onnx/onnx/4629?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) caused by PyTorch/Caffe2 tests. Pull Request resolved: pytorch#37309 Reviewed By: hl475 Differential Revision: D21288914 Pulled By: houseroad fbshipit-source-id: 15b076a2af55918dcd57f4e2fc77accd3d1510bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reverts BatchNormalization(12) spec (below commits) because it is not fully verified to work as it should.
Surgically removed batch norm specific changes from #2568
#2674
Unfortunately, this spec was one among the few specs that was checked in a rush between 02/2020 and 03/2020. Its presence has jeopardized ONNX 1.7 release but removing it will give us appropriate confidence level in the quality for ONNX 1.7 release.