[quant] Add backward compatiblity test#36639
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/286/basefrom
Closed
[quant] Add backward compatiblity test#36639jerryzh168 wants to merge 8 commits intogh/jerryzh168/286/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/286/basefrom
Conversation
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit e56a03c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 17 times. |
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
raghuramank100
suggested changes
Apr 16, 2020
Contributor
raghuramank100
left a comment
There was a problem hiding this comment.
Few more questions, thanks!
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
fmassa
reviewed
Apr 16, 2020
|
|
||
| # saving code : uncomment when adding a new test | ||
| # and run the new test, e.g. | ||
| # python test/quantization/test_backward_compatibility.py TestSerialization.test_conv3d |
Member
There was a problem hiding this comment.
I think the jit expect tests have an --accept flag that regenerates the expect files, maybe it would be useful to add this here?
Contributor
Author
There was a problem hiding this comment.
Actually, I think adding an extra argument will work for this case
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
raghuramank100
approved these changes
Apr 16, 2020
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Apr 16, 2020
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags:
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Apr 16, 2020
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags:
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Apr 16, 2020
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags:
Contributor
Author
|
closed in favior of #36771 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2020
Summary: re-created the same PR: #36639 because ghimport does not support importing binary files right now Pull Request resolved: #36771 Test Plan: python test/quantization/test_backward_compatibility.py Differential Revision: D21080503 Pulled By: jerryzh168 fbshipit-source-id: 1dca08208bccead60bba03e5fb5d39e1a1d7c20d
jerryzh168
added a commit
to jerryzh168/pytorch
that referenced
this pull request
Apr 17, 2020
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Test Plan: python test/quantization/test_backward_compatibility.py
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 18, 2020
Summary: re-created the same PR: #36639 because ghimport does not support importing binary files right now Pull Request resolved: #36842 Test Plan: python test/quantization/test_backward_compatibility.py Differential Revision: D21100689 Pulled By: jerryzh168 fbshipit-source-id: 625a0f9da98138c9c2891b9d99fc45d85fa27cca
karansachdev-1012
pushed a commit
to karansachdev-1012/pytorch
that referenced
this pull request
Feb 17, 2026
Summary: Add test for serialization to make sure the changes to serialization are backward compatible Test Plan: python test/quantization/test_backward_compatibility.py Reviewers: . Subscribers: Tasks: Tags: ghstack-source-id: 09abe3e Pull Request resolved: pytorch/pytorch#36639
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Pull Request resolved: pytorch#36771 Test Plan: python test/quantization/test_backward_compatibility.py Differential Revision: D21080503 Pulled By: jerryzh168 fbshipit-source-id: 1dca08208bccead60bba03e5fb5d39e1a1d7c20d
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: re-created the same PR: pytorch#36639 because ghimport does not support importing binary files right now Pull Request resolved: pytorch#36842 Test Plan: python test/quantization/test_backward_compatibility.py Differential Revision: D21100689 Pulled By: jerryzh168 fbshipit-source-id: 625a0f9da98138c9c2891b9d99fc45d85fa27cca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Add test for serialization to make sure the changes to serialization
are backward compatible
Test Plan:
python test/quantization/test_backward_compatibility.py
Reviewers:
.
Subscribers:
Tasks:
Tags: