[quant] ConvPackedParams with TorchBind#35923
Closed
jerryzh168 wants to merge 84 commits intogh/jerryzh168/282/basefrom
Closed
[quant] ConvPackedParams with TorchBind#35923jerryzh168 wants to merge 84 commits intogh/jerryzh168/282/basefrom
jerryzh168 wants to merge 84 commits intogh/jerryzh168/282/basefrom
Conversation
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit c88a383 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 426 times. |
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@jamesr66a do I need to change anything about ONNX? |
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@pytorchbot retest this please |
jamesr66a
reviewed
Apr 8, 2020
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Nice! I think the code looks good, but we're going to have to make sure this is solid from a compatibility standpoint. A few things that come to mind are:
- ONNX export. I had to do some shuffling in my PR to get that to work. The CI jobs should indicate whether this is needed or not
- ScriptModule BC. I added a comment inline in
test_backward_compatibility.pyabout this __torch_function__- dunno if this applies to Conv, but I ran into it in the RNN PR and I haven't figured out how to fix it yet
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
jamesr66a
approved these changes
Apr 30, 2020
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Great! Land if there are no more FBCode failures
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
Summary: Test Plan: tbd Reviewers: . Subscribers: Tasks: Tags: Differential Revision: [D20957089](https://our.internmc.facebook.com/intern/diff/D20957089) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
tbd
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D20957089