Skip to content

[JIT] List reland#36146

Closed
eellison wants to merge 2 commits intopytorch:masterfrom
eellison:list_reland
Closed

[JIT] List reland#36146
eellison wants to merge 2 commits intopytorch:masterfrom
eellison:list_reland

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented Apr 7, 2020

Relanding #33783

@eellison eellison requested a review from driazati April 7, 2020 16:37
@eellison eellison requested a review from apaszke as a code owner April 7, 2020 16:37
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 7, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 7, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 0682f21 (more details on the Dr. CI page):

  • 1/2 failures introduced in this PR

  • 1/2 broken upstream at merge base 82d58ed from Apr 05 until Apr 06 (10 commits; 81c8ca1 - cb385cb)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

XLA failure

Job pytorch_xla_linux_xenial_py3_6_clang7_build is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 3 times.

facebook-github-bot
facebook-github-bot reviewed Apr 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Apr 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 8, 2020

@eellison merged this pull request in 2afe171.

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Apr 8, 2020

I think that there is a reasonably high chance this is causing CUDA slow tests on master to start hanging

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Apr 8, 2020

example failure: https://app.circleci.com/jobs/github/pytorch/pytorch/5080997

ezyang added a commit that referenced this pull request Apr 8, 2020
@ezyang
Revert "[JIT] List reland (#36146)"
7b68a2a 
This reverts commit 2afe171.
ashishfarmer pushed a commit to ashishfarmer/pytorch that referenced this pull request Apr 13, 2020
[JIT] List reland (pytorch#36146)
f5deb95 
Summary:
Relanding pytorch#33783
Pull Request resolved: pytorch#36146

Differential Revision: D20895316

Pulled By: eellison

fbshipit-source-id: 9a2bc0e6bdcbd43f9abe51eadaa28f90bccafcc9
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[JIT] List reland (pytorch#36146)
0b9cce1 
Summary:
Relanding pytorch#33783
Pull Request resolved: pytorch#36146

Differential Revision: D20895316

Pulled By: eellison

fbshipit-source-id: 9a2bc0e6bdcbd43f9abe51eadaa28f90bccafcc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eellison @facebook-github-bot @ezyang @driazati @mruberry