[JIT] add support for torch.norm#33783
Closed
eellison wants to merge 10 commits intogh/eellison/58/basefrom
Closed
[JIT] add support for torch.norm#33783eellison wants to merge 10 commits intogh/eellison/58/basefrom
eellison wants to merge 10 commits intogh/eellison/58/basefrom
Conversation
[ghstack-poisoned]
This was referenced Feb 25, 2020
[ghstack-poisoned]
vishwakftw
reviewed
Feb 25, 2020
| elif dtype is None: | ||
| return torch._C._VariableFunctions.norm(input, p, dim, keepdim=keepdim, out=out) | ||
| return torch._C._VariableFunctions.norm(input, p, dim, keepdim=keepdim, dtype=dtype, out=out) | ||
| dim = [i for i in range(ndim)] # noqa: C416 TODO: rewrite as list(range(m)) |
Contributor
There was a problem hiding this comment.
I noticed this in at least one other preceding PR as well, perhaps we could consider adding this as a separate function to reduce duplicate code.
Contributor
Author
There was a problem hiding this comment.
Sounds good. I’m also going to try to add list(range()) support to TS in the next week
|
|
||
| def norm(): | ||
| c = torch.tensor([[1, 2, 3], [-1, 1, 4]], dtype=torch.float) | ||
| return torch.norm(c, p="fro"), torch.norm(c, p="nuc"), torch.norm(c), torch.norm(c, p=.5) |
Contributor
There was a problem hiding this comment.
Is it not necessary to test with different function arguments, or are they left out since they are covered by standard tests in test_torch
Contributor
Author
There was a problem hiding this comment.
Yea, I was mostly testing that it compiles with different types of arguments. Since test_torch tests with different argument values and the code is the same for python/TorchScript, that should be sufficient
💊 CircleCI build failures summary and remediationsAs of commit ce36b72 (more details on the Dr. CI page): Commit ce36b72 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 51 times. |
Fix for #20113 [ghstack-poisoned]
Fix for #20113 [ghstack-poisoned]
driazati
approved these changes
Feb 26, 2020
added 5 commits
February 26, 2020 14:33
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Fix for #20113 Differential Revision: [D20121917](https://our.internmc.facebook.com/intern/diff/D20121917) [ghstack-poisoned]
Contributor
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2020
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
Summary: Relanding pytorch#33783 Pull Request resolved: pytorch#36146 Differential Revision: D20895316 Pulled By: eellison fbshipit-source-id: 9a2bc0e6bdcbd43f9abe51eadaa28f90bccafcc9
facebook-github-bot
pushed a commit
that referenced
this pull request
May 13, 2020
Summary: Fix for #37986 Follows the stack in #33783 stack to make functions in `torch/functional.py` resolve to their python implementations. Because the return type of `torch.unique` depends on `return_inverse` and `return_counts` I had to refactor the implementation to use our boolean_dispatch mechanism. Pull Request resolved: #38156 Differential Revision: D21504449 Pulled By: eellison fbshipit-source-id: 7efb1dff3b5c00655da10168403ac4817286ff59
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Jun 1, 2020
Summary: Fix for pytorch#37986 Follows the stack in pytorch#33783 stack to make functions in `torch/functional.py` resolve to their python implementations. Because the return type of `torch.unique` depends on `return_inverse` and `return_counts` I had to refactor the implementation to use our boolean_dispatch mechanism. Pull Request resolved: pytorch#38156 Differential Revision: D21504449 Pulled By: eellison fbshipit-source-id: 7efb1dff3b5c00655da10168403ac4817286ff59
gchanan
pushed a commit
that referenced
this pull request
Jun 2, 2020
Summary: Fix for #37986 Follows the stack in #33783 stack to make functions in `torch/functional.py` resolve to their python implementations. Because the return type of `torch.unique` depends on `return_inverse` and `return_counts` I had to refactor the implementation to use our boolean_dispatch mechanism. Pull Request resolved: #38156 Differential Revision: D21504449 Pulled By: eellison fbshipit-source-id: 7efb1dff3b5c00655da10168403ac4817286ff59
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#33783 Fix for pytorch#20113 Test Plan: Imported from OSS Differential Revision: D20121917 Pulled By: eellison fbshipit-source-id: ffedcc40678cd80f5529ff9323088eed544e5158
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Relanding pytorch#33783 Pull Request resolved: pytorch#36146 Differential Revision: D20895316 Pulled By: eellison fbshipit-source-id: 9a2bc0e6bdcbd43f9abe51eadaa28f90bccafcc9
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fix for pytorch#37986 Follows the stack in pytorch#33783 stack to make functions in `torch/functional.py` resolve to their python implementations. Because the return type of `torch.unique` depends on `return_inverse` and `return_counts` I had to refactor the implementation to use our boolean_dispatch mechanism. Pull Request resolved: pytorch#38156 Differential Revision: D21504449 Pulled By: eellison fbshipit-source-id: 7efb1dff3b5c00655da10168403ac4817286ff59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix for #20113
Differential Revision: D20121917