Skip to content

Move libtorch to py3 and cleanup other CircleCI config#35700

Closed
orionr wants to merge 1 commit intopytorch:masterfrom
orionr:move-libtorch-to-py3
Closed

Move libtorch to py3 and cleanup other CircleCI config#35700
orionr wants to merge 1 commit intopytorch:masterfrom
orionr:move-libtorch-to-py3

Conversation

@orionr
Copy link
Copy Markdown
Contributor

@orionr orionr commented Mar 30, 2020

This moves libtorch to Python 3.6 and cleans up other CircleCI config for the removal of python2.

Going to see if all tests pass on this and will also land before #35677

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 30, 2020

💊 CircleCI build failures summary and remediations

As of commit ee10429 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base e3daf70 from Mar 27 until Mar 30 (53 commits; b9adbb5 - 35dbc6e)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 3 times.

@orionr orionr changed the title [WIP] Move libtorch to py3 and cleanup other CircleCI config Move libtorch to py3 and cleanup other CircleCI config Mar 31, 2020
@orionr orionr requested review from kostmo, malfet and seemethere March 31, 2020 15:20
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@orionr merged this pull request in 3d6b5ba.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
This moves libtorch to Python 3.6 and cleans up other CircleCI config for the removal of python2.

Going to see if all tests pass on this and will also land before pytorch#35677
Pull Request resolved: pytorch#35700

Differential Revision: D20767830

Pulled By: orionr

fbshipit-source-id: 0d5a8224b65829cc2b08a5844707e0c0e079421a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants