Skip to content

Remove python2 and 3.5 from requirements.txt, README and docs#35677

Closed
orionr wants to merge 1 commit intopytorch:masterfrom
orionr:remove-python2-readme
Closed

Remove python2 and 3.5 from requirements.txt, README and docs#35677
orionr wants to merge 1 commit intopytorch:masterfrom
orionr:remove-python2-readme

Conversation

@orionr
Copy link
Copy Markdown
Contributor

@orionr orionr commented Mar 30, 2020

Some more cleanup now that we no longer support python2 or 3.5 on master and eventually PyTorch 1.6 release.

@orionr orionr requested review from malfet and seemethere March 30, 2020 15:39
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 30, 2020

💊 CircleCI build failures summary and remediations

As of commit d3d7053 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 36 times.

@orionr orionr changed the title Remove python2 and 3.5 references from README and docs Remove python2 and 3.5 from requirements.txt, README and docs Mar 30, 2020
@orionr
Copy link
Copy Markdown
Contributor Author

orionr commented Mar 30, 2020

Looks like I'll need to move libtorch over first. Coming up!

@orionr orionr changed the title Remove python2 and 3.5 from requirements.txt, README and docs [WIP] Remove python2 and 3.5 from requirements.txt, README and docs Mar 30, 2020
facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2020
Summary:
This moves libtorch to Python 3.6 and cleans up other CircleCI config for the removal of python2.

Going to see if all tests pass on this and will also land before #35677
Pull Request resolved: #35700

Differential Revision: D20767830

Pulled By: orionr

fbshipit-source-id: 0d5a8224b65829cc2b08a5844707e0c0e079421a
@orionr orionr force-pushed the remove-python2-readme branch 2 times, most recently from 7dcdcd0 to c823f4f Compare April 1, 2020 16:06
@orionr orionr force-pushed the remove-python2-readme branch from 6998f6c to 1b6817f Compare April 2, 2020 19:03
@orionr orionr changed the title [WIP] Remove python2 and 3.5 from requirements.txt, README and docs Remove python2 and 3.5 from requirements.txt, README and docs Apr 2, 2020
@orionr orionr force-pushed the remove-python2-readme branch from 558d26b to 01181fe Compare April 2, 2020 22:45
@orionr orionr force-pushed the remove-python2-readme branch from 01181fe to d3d7053 Compare April 3, 2020 01:34
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@orionr merged this pull request in 2d8dbcd.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
This moves libtorch to Python 3.6 and cleans up other CircleCI config for the removal of python2.

Going to see if all tests pass on this and will also land before pytorch#35677
Pull Request resolved: pytorch#35700

Differential Revision: D20767830

Pulled By: orionr

fbshipit-source-id: 0d5a8224b65829cc2b08a5844707e0c0e079421a
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…h#35677)

Summary:
Some more cleanup now that we no longer support python2 or 3.5 on master and eventually PyTorch 1.6 release.
Pull Request resolved: pytorch#35677

Differential Revision: D20838097

Pulled By: orionr

fbshipit-source-id: 95d553a1e8769f3baa395e0bc6d4ce7cd93236e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants