Revert "Load torch_global_deps for Windows (#35177)"#35355
Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Closed
Revert "Load torch_global_deps for Windows (#35177)"#35355peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123 wants to merge 1 commit intopytorch:masterfrom
Conversation
This reverts commit d7a7bcb.
💊 CircleCI build failures summary and remediationsAs of commit 04b8de7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
malfet
approved these changes
Mar 25, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
@pytorchbot merge this please |
Contributor
iotamudelta
added a commit
to ROCm/pytorch
that referenced
this pull request
Mar 30, 2020
Revert "Load torch_global_deps for Windows (pytorch#35177)" (pytorch#35355)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d7a7bcb.
The previous commit is not useful because torch_global_deps doesn't include any external dependencies.