Skip to content

Load torch_global_deps for Windows#35177

Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123:windows_global_deps
Closed

Load torch_global_deps for Windows#35177
peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123:windows_global_deps

Conversation

@peterjc123
Copy link
Collaborator

@peterjc123 peterjc123 commented Mar 22, 2020

@peterjc123 peterjc123 requested review from ezyang and soumith March 22, 2020 07:18
@peterjc123 peterjc123 force-pushed the windows_global_deps branch from 9fd5e63 to 1d9b7ad Compare March 22, 2020 07:20
@dr-ci
Copy link

dr-ci bot commented Mar 22, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 1d9b7ad (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 1/1 broken upstream at merge base cfc0ff1 since Mar 21

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

facebook-github-bot
facebook-github-bot reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2020

@ezyang merged this pull request in d7a7bcb.

@peterjc123 peterjc123 deleted the windows_global_deps branch March 24, 2020 16:15
peterjc123 added a commit to peterjc123/pytorch that referenced this pull request Mar 25, 2020
@peterjc123
Revert "Load torch_global_deps for Windows (pytorch#35177)"
04b8de7 
This reverts commit d7a7bcb.
facebook-github-bot pushed a commit that referenced this pull request Mar 26, 2020
@peterjc123 @facebook-github-bot
Revert "Load torch_global_deps for Windows (#35177)" (#35355)
4a4e385 
Summary:
This reverts commit d7a7bcb.

The previous commit is not useful because torch_global_deps doesn't include any external dependencies.
Pull Request resolved: #35355

Differential Revision: D20653036

Pulled By: ezyang

fbshipit-source-id: 6d2e2f90952ca865b27b649a6ff9114ada8ea78c
iotamudelta added a commit to ROCm/pytorch that referenced this pull request Mar 30, 2020
@iotamudelta
Merge pull request #614 from iotamudelta/ifu_20200326_2
1498a88 
Revert "Load torch_global_deps for Windows (pytorch#35177)" (pytorch#35355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterjc123 @facebook-github-bot @ezyang @pytorchbot @mruberry