Skip to content

fix complex conversions on cuda#35344

Closed
ngimel wants to merge 3 commits intopytorch:masterfrom
ngimel:complex_conversion
Closed

fix complex conversions on cuda#35344
ngimel wants to merge 3 commits intopytorch:masterfrom
ngimel:complex_conversion

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Mar 25, 2020

Fixes #35225.

@ngimel ngimel requested review from anjali411 and zasdfgbnm March 25, 2020 00:56
@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit 104f9d1 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 14 times.

Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the issue #35225 :D

@ngimel ngimel force-pushed the complex_conversion branch from 038de5f to e4bb775 Compare March 25, 2020 18:28
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 8d720b7.

facebook-github-bot pushed a commit that referenced this pull request Mar 27, 2020
#35528)

Summary:
copy_() launch failure fixed on cuda for complex #35344  so removing the workaround added in PR #34093
Pull Request resolved: #35528

Differential Revision: D20693228

Pulled By: anjali411

fbshipit-source-id: dbb6369aa5a21574a0a4fe878ca10e4ecc605f6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RuntimeError] copy_() : CUDA error: unspecified launch failure

5 participants