Skip to content

copy_ fixed on cuda so removing the workaround in test_many_promotions#35528

Closed
anjali411 wants to merge 1 commit intopytorch:masterfrom
anjali411:copy_complex
Closed

copy_ fixed on cuda so removing the workaround in test_many_promotions#35528
anjali411 wants to merge 1 commit intopytorch:masterfrom
anjali411:copy_complex

Conversation

@anjali411
Copy link
Contributor

copy_() launch failure fixed on cuda for complex #35344 so removing the workaround added in PR #34093

@anjali411 anjali411 requested a review from nairbv March 27, 2020 11:38
@anjali411 anjali411 added module: type promotion Related to semantics of type promotion module: complex Related to complex number support in PyTorch labels Mar 27, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Mar 27, 2020

💊 CircleCI build failures summary and remediations

As of commit ab8b257 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 4/4 broken upstream at merge base e5cd17c on Mar 27 from 7:39am to 1:51pm (2 commits; 025a0ab - 45e1be9)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 3 upstream failures:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 4 times.

@facebook-github-bot
Copy link
Contributor

@anjali411 merged this pull request in 3c02de0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: complex Related to complex number support in PyTorch module: type promotion Related to semantics of type promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants