fix missing comma in activation benchmarks#35104
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/14/basefrom
Closed
fix missing comma in activation benchmarks#35104vkuzo wants to merge 1 commit intogh/vkuzo/14/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/14/basefrom
Conversation
Summary: I missed this in #34959 after a rebase, fixing. Test Plan: running benchmarks no longer crashes CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CircleCI build failures summary and remediationsAs of commit 9d32d4c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
|
This pull request has been merged in bf41a76. |
1 similar comment
Contributor
|
This pull request has been merged in bf41a76. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#35104 I missed this in pytorch#34959 after a rebase, fixing. Test Plan: running benchmarks no longer crashes CI Imported from OSS Differential Revision: D20560908 fbshipit-source-id: a5494e23953d3c9007e9874d673896291b5322e0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
I missed this in #34959
after a rebase, fixing.
Test Plan:
running benchmarks no longer crashes
CI
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D20560908